fix empty route being ignored on insert #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
reviewed
Jul 30, 2025
When constructing the tree, if the first route is the empty string `""` the root would be overwritten due to the `self.prefix.is_empty()`. This adds an additional check to ensure the root is actually `None` before returning a root node. Resolves ibraheemdev#75
Owner
|
Thanks! The CI failure is unrelated. |
pipex
added a commit
to balena-io-modules/mahler-rs
that referenced
this pull request
Aug 1, 2025
Inconsistent behavior would happen when inserting an empty route first in the domain. This was traced to the matchit dependency and fixed on ibraheemdev/matchit#76, this update that dependency to that revision Change-type: patch
pipex
added a commit
to balena-io-modules/mahler-rs
that referenced
this pull request
Aug 1, 2025
Inconsistent behavior would happen when inserting an empty route first in the domain. This was traced to the matchit dependency and fixed on ibraheemdev/matchit#76, this update that dependency to that revision Change-type: patch
pipex
added a commit
to balena-io-modules/mahler-rs
that referenced
this pull request
Aug 8, 2025
We need to wait for a new version of matchit to include the release ibraheemdev/matchit#76 Change-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing the tree, if the first route is the empty string
""the root would be overwritten due to theself.prefix.is_empty().This adds an additional check to ensure the root is actually
Nonebefore returning a root node.Resolves #75