Refactoring, adding tests and installing instructions#23
Open
garciadias wants to merge 14 commits intoibrahimethemhamamci:mainfrom
Open
Refactoring, adding tests and installing instructions#23garciadias wants to merge 14 commits intoibrahimethemhamamci:mainfrom
garciadias wants to merge 14 commits intoibrahimethemhamamci:mainfrom
Conversation
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
…djust padding values, and streamline function definitions. Signed-off-by: R. Garcia-Dias <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Ibrahim,
I am an ML engineer at King's College London. I am working on building Visual Language models on MRI, and your work is very similar to the type of architecture I am trying to create.
Congratulations on your article, and thank you for sharing the code.
Since I will use your code as a baseline comparison and inspiration for my development, I decided to clean and refactor the code. I am sharing here a PR to include tests, python environment settings and docker instructions to easily build and run the code.
For this PR, I tried not to change the code in any significant way. There were some undefined variables and errors that I had to fix in order to run the tests, but they are very minimal.
Here you can see the output of running the tests:
If you are happy to collaborate, I would keep sending PRs to improve the code, eliminate duplications and improve test coverage.
I am also a MONAI collaborator, so I would happily help you get your model listed on MONAI bundles.
Many thanks,
Rafael