Adjust test naming

Author: icanhazstring

tests/Unit/Template/Renderer/PlatesRendererTest.php

@@ -11,6 +11,12 @@
 use Vfs\Node\Directory;
 use Vfs\Node\File;
 
+/**
+ * PlatesRendererTest
+ *
+ * @package SystemCtl\Test\Unit\Template\Renderer
+ * @author  icanhazstring <[email protected]>
+ */
 class PlatesRendererTest extends TestCase
 {
     /** @var FileSystem */

tests/Unit/Template/Section/InstallSectionTest.php

@@ -6,15 +6,27 @@
 use SystemCtl\Exception\PropertyNotSupportedException;
 use SystemCtl\Template\Section\InstallSection;
 
+/**
+ * InstallSectionTest
+ *
+ * @package SystemCtl\Test\Unit\Template\Section
+ * @author  icanhazstring <[email protected]>
+ */
 class InstallSectionTest extends TestCase
 {
-    public function testCreation()
+    /**
+     * @test
+     */
+    public function itShouldCreateProperInstance()
     {
         $installSection = new InstallSection;
         $this->assertInstanceOf(InstallSection::class, $installSection);
     }
 
-    public function testValidProperties()
+    /**
+     * @test
+     */
+    public function itShouldSetPropertiesAndReturnThem()
     {
         $installSection = (new InstallSection)
             ->setAlias(['alias'])
@@ -28,21 +40,30 @@ public function testValidProperties()
         $this->assertEquals(['also'], $installSection->getAlso());
     }
 
-    public function testInvalidPropertyShouldRaiseException()
+    /**
+     * @test
+     */
+    public function itShouldRaiseAnExceptionOnInvalidProperty()
     {
         $installSection = new InstallSection;
 
         $this->expectException(PropertyNotSupportedException::class);
         $installSection->setFubar('should fail');
     }
 
-    public function testNonSetPropertyShouldReturnNull()
+    /**
+     * @test
+     */
+    public function itShouldReturnNullIfAPropertyIsNotSet()
     {
         $installSection = new InstallSection;
         $this->assertNull($installSection->getWantedBy());
     }
 
-    public function testGetPropetiesShouldReturnOnlySetProperties()
+    /**
+     * @test
+     */
+    public function itShouldReturnOnlyThosePropertiesPreviouslySet()
     {
         $installSection = new InstallSection;
 

tests/Unit/Template/Section/ServiceSectionTest.php

@@ -3,18 +3,30 @@
 namespace SystemCtl\Test\Unit\Template\Section;
 
 use PHPUnit\Framework\TestCase;
-use SystemCtl\Exception\PropertyNotSupportedException;
 use SystemCtl\Template\Section\ServiceSection;
 
+/**
+ * ServiceSectionTest
+ *
+ * @package SystemCtl\Test\Unit\Template\Section
+ * @author  icanhazstring <[email protected]>
+ */
 class ServiceSectionTest extends TestCase
 {
-    public function testCreation()
+
+    /**
+     * @test
+     */
+    public function itShouldCreateProperInstance()
     {
         $serviceSection = new ServiceSection;
         $this->assertInstanceOf(ServiceSection::class, $serviceSection);
     }
 
-    public function testValidProperties()
+    /**
+     * @test
+     */
+    public function itShouldSetPropertiesAndReturnThem()
     {
         $serviceSection = (new ServiceSection)
             ->setType(ServiceSection::TYPE_FORKING)
@@ -38,21 +50,10 @@ public function testValidProperties()
         $this->assertEquals('pid', $serviceSection->getPIDFile());
     }
 
-    public function testInvalidPropertyShouldRaiseException()
-    {
-        $serviceSection = new ServiceSection;
-
-        $this->expectException(PropertyNotSupportedException::class);
-        $serviceSection->setFubar('should fail');
-    }
-
-    public function testNonSetPropertyShouldReturnNull()
-    {
-        $serviceSection = new ServiceSection;
-        $this->assertNull($serviceSection->getEnvironment());
-    }
-
-    public function testGetPropetiesShouldReturnOnlySetProperties()
+    /**
+     * @test
+     */
+    public function itShouldReturnOnlyThosePropertiesPreviouslySet()
     {
         $serviceSection = new ServiceSection;
 

tests/Unit/Template/Section/TimerSectionTest.php

@@ -3,18 +3,29 @@
 namespace SystemCtl\Test\Unit\Template\Section;
 
 use PHPUnit\Framework\TestCase;
-use SystemCtl\Exception\PropertyNotSupportedException;
 use SystemCtl\Template\Section\TimerSection;
 
+/**
+ * TimerSectionTest
+ *
+ * @package SystemCtl\Test\Unit\Template\Section
+ * @author  icanhazstring <[email protected]>
+ */
 class TimerSectionTest extends TestCase
 {
-    public function testCreation()
+    /**
+     * @test
+     */
+    public function itShouldCreateProperInstance()
     {
         $timerSection = new TimerSection;
         $this->assertInstanceOf(TimerSection::class, $timerSection);
     }
 
-    public function testValidProperties()
+    /**
+     * @test
+     */
+    public function itShouldSetPropertiesAndReturnThem()
     {
         $timerSection = (new TimerSection)
             ->setOnCalendar('Wed..Sat *-*-* 1:00')
@@ -26,21 +37,10 @@ public function testValidProperties()
         $this->assertFalse($timerSection->shouldRemainAfterElapse());
     }
 
-    public function testInvalidPropertyShouldRaiseException()
-    {
-        $timerSection = new TimerSection;
-
-        $this->expectException(PropertyNotSupportedException::class);
-        $timerSection->setFubar('should fail');
-    }
-
-    public function testNonSetPropertyShouldReturnNull()
-    {
-        $timerSection = new TimerSection;
-        $this->assertNull($timerSection->getOnCalendar());
-    }
-
-    public function testGetPropetiesShouldReturnOnlySetProperties()
+    /**
+     * @test
+     */
+    public function itShouldReturnOnlyThosePropertiesPreviouslySet()
     {
         $timerSection = new TimerSection;
 

tests/Unit/Template/Section/UnitSectionTest.php

@@ -3,18 +3,29 @@
 namespace SystemCtl\Test\Unit\Template\Section;
 
 use PHPUnit\Framework\TestCase;
-use SystemCtl\Exception\PropertyNotSupportedException;
 use SystemCtl\Template\Section\UnitSection;
 
+/**
+ * UnitSectionTest
+ *
+ * @package SystemCtl\Test\Unit\Template\Section
+ * @author  icanhazstring <[email protected]>
+ */
 class UnitSectionTest extends TestCase
 {
-    public function testCreation()
+    /**
+     * @test
+     */
+    public function itShouldCreateProperInstance()
     {
         $unitSection = new UnitSection;
         $this->assertInstanceOf(UnitSection::class, $unitSection);
     }
 
-    public function testValidProperties()
+    /**
+     * @test
+     */
+    public function itShouldSetPropertiesAndReturnThem()
     {
         $unitSection = (new UnitSection)
             ->setDescription('TestDescription')
@@ -32,21 +43,10 @@ public function testValidProperties()
         $this->assertEquals(['g', 'h'], $unitSection->getConflicts());
     }
 
-    public function testInvalidPropertyShouldRaiseException()
-    {
-        $unitSection = new UnitSection;
-
-        $this->expectException(PropertyNotSupportedException::class);
-        $unitSection->setFubar('should fail');
-    }
-
-    public function testNonSetPropertyShouldReturnNull()
-    {
-        $unitSection = new UnitSection;
-        $this->assertNull($unitSection->getDescription());
-    }
-
-    public function testGetPropetiesShouldReturnOnlySetProperties()
+    /**
+     * @test
+     */
+    public function itShouldReturnOnlyThosePropertiesPreviouslySet()
     {
         $unitSection = new UnitSection;
 

tests/Unit/Template/ServiceUnitTemplateTest.php

@@ -9,9 +9,18 @@
 use SystemCtl\Template\ServiceUnitTemplate;
 use SystemCtl\Unit\Service;
 
+/**
+ * ServiceUnitTemplateTest
+ *
+ * @package SystemCtl\Test\Unit\Template
+ * @author  icanhazstring <[email protected]>
+ */
 class ServiceUnitTemplateTest extends TestCase
 {
-    public function testSimpleUnitCreation()
+    /**
+     * @test
+     */
+    public function itShouldCreateASimpleInstance()
     {
         $unitTemplate = new ServiceUnitTemplate('TestService');
 
@@ -20,7 +29,10 @@ public function testSimpleUnitCreation()
         $this->assertEquals('TestService', $unitTemplate->getName());
     }
 
-    public function testEmptySectionAfterCreation()
+    /**
+     * @test
+     */
+    public function itShouldReturnEmptySectionsAfterInstantiation()
     {
         $unitTemplate = new ServiceUnitTemplate('TestService');
 
@@ -34,7 +46,10 @@ public function testEmptySectionAfterCreation()
         $this->assertEmpty($unitTemplate->getServiceSection()->getProperties());
     }
 
-    public function testUnitCreationWithSections()
+    /**
+     * @test
+     */
+    public function itShouldReturnProperSectionValuesIfSet()
     {
         $unitTemplate = new ServiceUnitTemplate('TestService');
 

tests/Unit/Template/TimerUnitTemplateTest.php

@@ -9,9 +9,18 @@
 use SystemCtl\Template\TimerUnitTemplate;
 use SystemCtl\Unit\Timer;
 
+/**
+ * TimerUnitTemplateTest
+ *
+ * @package SystemCtl\Test\Unit\Template
+ * @author  icanhazstring <[email protected]>
+ */
 class TimerUnitTemplateTest extends TestCase
 {
-    public function testSimpleUnitCreation()
+    /**
+     * @test
+     */
+    public function itShouldCreateASimpleInstance()
     {
         $unitTemplate = new TimerUnitTemplate('TestTimer');
 
@@ -20,7 +29,10 @@ public function testSimpleUnitCreation()
         $this->assertEquals('TestTimer', $unitTemplate->getName());
     }
 
-    public function testEmptySectionAfterCreation()
+    /**
+     * @test
+     */
+    public function itShouldReturnEmptySectionsAfterInstantiation()
     {
         $unitTemplate = new TimerUnitTemplate('TestTimer');
 
@@ -34,7 +46,10 @@ public function testEmptySectionAfterCreation()
         $this->assertEmpty($unitTemplate->getTimerSection()->getProperties());
     }
 
-    public function testUnitCreationWithSections()
+    /**
+     * @test
+     */
+    public function itShouldReturnProperSectionValuesIfSet()
     {
         $unitTemplate = new TimerUnitTemplate('TestTimer');