Drop support for unitFromSuffix

Author: icanhazstring

src/SystemCtl.php

@@ -64,29 +64,6 @@ public static function setTimeout(int $timeout): void
         self::$timeout = $timeout;
     }
 
-    /**
-     * @param string $unitSuffix
-     * @param string $unitName
-     *
-     * @return UnitInterface
-     * @throws UnitTypeNotSupportedException
-     * @deprecated This static method is deprecated, please refer to a specifc get method for a unit
-     */
-    public static function unitFromSuffix(string $unitSuffix, string $unitName): UnitInterface
-    {
-        $unitClass = 'SystemCtl\\Unit\\' . ucfirst($unitSuffix);
-
-        if (!class_exists($unitClass)) {
-            throw new UnitTypeNotSupportedException('Unit type ' . $unitSuffix . ' not supported');
-        }
-
-        $commandDispatcher = (new SymfonyCommandDispatcher)
-            ->setTimeout(self::$timeout)
-            ->setBinary(self::$binary);
-
-        return new $unitClass($unitName, $commandDispatcher);
-    }
-
     /**
      * List all supported units
      *

tests/Integration/SystemCtlTest.php

@@ -89,20 +89,6 @@ public function testListUnitsWithSupportedUnits()
         $this->assertCount(5, $units);
     }
 
-    public function testCreateUnitFromSupportedSuffixShouldWord()
-    {
-        $unit = SystemCtl::unitFromSuffix('service', 'SuccessService');
-        $this->assertInstanceOf(UnitInterface::class, $unit);
-        $this->assertInstanceOf(Service::class, $unit);
-        $this->assertEquals('SuccessService', $unit->getName());
-    }
-
-    public function testCreateUnitFromUnsupportedSuffixShouldRaiseException()
-    {
-        $this->expectException(UnitTypeNotSupportedException::class);
-        SystemCtl::unitFromSuffix('unsupported', 'FailUnit');
-    }
-
     public function testGetServices()
     {
         $output = <<<EOT