Implement Dominated Novelty Search #664

ryanboldi · 2025-11-18T01:38:33Z

Description

Add Dominated Novelty Search (https://arxiv.org/abs/2502.00593) as an archive to be used in pyres

TODO

Status

I have read the guidelines in
CONTRIBUTING.md
I have linted and formatted my code with ruff and ty
I have tested my code by running pytest
I have added a description of my change to the changelog in HISTORY.md
This PR is ready to go

btjanaka · 2025-11-21T22:15:55Z

Hi @ryanboldi, thanks for sending in this PR! Is it ready for review yet?

ryanboldi · 2025-11-21T22:28:05Z

Hi @btjanaka! Yep it is ready for review. I am still working on the tutorial notebook but I believe they are independent for the sake of code review.

Thanks!

btjanaka · 2025-11-23T23:49:03Z

Hi @btjanaka! Yep it is ready for review. I am still working on the tutorial notebook but I believe they are independent for the sake of code review.

Thanks!

Awesome I'll try to take a look next week!

btjanaka

Hi @ryanboldi, thank you for your patience! I've gone through the PR and left some comments. I hope you find them helpful! I've mainly pointed out little things in the implementation and tests. I am happy to accept the PR with these fixes and also with a few more tests. If you have time after that, it would be really helpful if we could get an example of DNS running so that we basically "battle test" this implementation and determine if there are any bugs of performance bottlenecks. Some ideas include an addition to the examples/sphere.py script where we currently dump many of our algorithms, or the tutorial that you mentioned. Thanks again for working on this!

tests/archives/dns_archive_test.py

ribs/archives/_dns_archive.py

tests/archives/dns_archive_test.py

ribs/archives/_dns_archive.py

ryanboldi · 2025-12-09T16:04:37Z

Thanks for the detailed feedback! I tried to make the changes you requested. Would appreciate a second review when you get a chance.

## Description  Added dtypes for np.asarray in methods like retrieve and index_of across all the archives. Credit to #664 for pointing this out in DNSArchive's retrieve method. ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have linted and formatted my code with `ruff` and `ty` - [x] I have tested my code by running `pytest` - [x] I have added a description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go

btjanaka

Hi @ryanboldi, thanks for making these changes! I had a couple questions regarding your PR; could you take a look at those? Also, please make sure to pull before making any new changes, as I made some edits to your code. I think we are pretty close to merging!

btjanaka · 2025-12-09T23:52:33Z

ribs/archives/_dns_archive.py


-    def compute_dns(self, measures: ArrayLike, objectives: ArrayLike) -> np.ndarray:
-        """Computes DNS scores for a batch against the current population.
+    def _compute_dns(self, measures: ArrayLike, objectives: ArrayLike) -> np.ndarray:


I notice you switched this to a private method. Are there cases where people would want to compute the DNS score without adding to the archive? For example, maybe someone wants to make a heatmap showing the DNS score across the archive? In such a case, a public API would be useful.

btjanaka · 2025-12-10T01:29:55Z

ribs/archives/_dns_archive.py

        check_shape(measures, "measures", self.measure_dim, "measure_dim")
        check_finite(measures, "measures")
-        return self.index_of(measures[None])[0]
+        return int(self.index_of(measures[None])[0])


Any reason why this has to be cast to int? Since you are calling index_of, which casts to int32, this should also end up being int32.

btjanaka · 2025-12-10T01:41:43Z

ribs/archives/_dns_archive.py

+            for name in self._store.field_list:
+                combined[name] = (
+                    np.concatenate((cur[name], data[name]), axis=0)
+                    if name in data


Maybe we should throw an error instead for the case when if name not in data? I don't imagine your code will behave very nicely if you continue to use combined with some entries being longer than others.

btjanaka · 2025-12-10T01:52:53Z

ribs/archives/_dns_archive.py

        if n_total <= cap:
            survivor_indices = np.arange(n_total)
        else:
            # Take largest `cap` values.


I think this can be done with:

survivor_indices = np.argsort(dns_scores)[-cap:]

Does that achieve what you intend?

btjanaka · 2025-12-10T01:55:47Z

ribs/archives/_dns_archive.py

@@ -456,11 +378,23 @@

        # Update stats.
        if len(self) > 0:


Is there any case where adding will result in the archive shrinking in size? If so, this if statement would cause the archive stats to no longer be current.

btjanaka · 2025-12-10T01:58:40Z

ribs/archives/_dns_archive.py

+        check_batch_shape(measures, "measures", self.measure_dim, "measure_dim")
+        check_finite(measures, "measures")
+
+        occupied, data = cast(


Any reason why this has to be cast?

btjanaka · 2025-12-11T07:41:50Z

ribs/archives/_dns_archive.py

+        if self.empty:
+            raise IndexError("No elements in archive.")
+
+        # Deterministic selection: return the first n elites (in storage order).


Why does this have to be deterministic selection?

btjanaka · 2025-12-11T07:42:01Z

ribs/archives/_dns_archive.py

+    ) -> np.ndarray | BatchData | tuple[np.ndarray] | ArchiveDataFrame:
+        return self._store.data(fields, return_type)
+
+    def sample_elites(self, n: Int) -> BatchData:


Note to self: Add replace parameter?

ryanboldi added 4 commits October 31, 2025 14:39

Add DNS archive

6e986e6

add tests

9d0d8b3

formatting + type fixing for DNS

3edad09

Update History

4fe1838

btjanaka added 3 commits December 1, 2025 17:50

history

f10701b

Merge branch 'master' into dns

5bef918

Edit docstring

be272cf

btjanaka requested changes Dec 2, 2025

View reviewed changes

btjanaka and others added 6 commits December 3, 2025 18:46

Switch cKDTree to KDTree

2290f05

Merge branch 'master' into dns

f676860

Merge branch 'master' into dns

59ca28f

Merge branch 'master' into dns

b042328

Merge branch 'master' into dns

744b8d2

improve dns implementation

2f9cc84

Revert type annotation for data

0d4596a

btjanaka mentioned this pull request Dec 9, 2025

Use dtypes when calling asarray in archive methods #673

Merged

5 tasks

btjanaka added 2 commits December 9, 2025 15:48

Edit docstring

3115227

Remove space in class params

cb3d682

btjanaka added 2 commits December 9, 2025 16:10

Merge branch 'master' into dns

6edda83

Add stats declaration

b8c5dd8

btjanaka reviewed Dec 10, 2025

View reviewed changes

btjanaka added this to the v0.9.0 milestone Dec 10, 2025

btjanaka added 2 commits December 9, 2025 21:15

Merge branch 'master' into dns

7b4a208

Replace ckdtree with kdtree

d4ed4e5

btjanaka added 4 commits December 9, 2025 23:38

Merge branch 'master' into dns

970b349

Merge branch 'master' into dns

254b6de

Merge branch 'master' into dns

e434a3c

Merge branch 'master' into dns

e3ec797

btjanaka reviewed Dec 11, 2025

View reviewed changes

btjanaka added 2 commits December 16, 2025 21:06

Merge branch 'master' into dns

4d45ef2

Merge branch 'master' into dns

f0c4d73

Implement Dominated Novelty Search #664

Are you sure you want to change the base?

Implement Dominated Novelty Search #664

Uh oh!

Conversation

ryanboldi commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

TODO

Status

Uh oh!

btjanaka commented Nov 21, 2025

Uh oh!

ryanboldi commented Nov 21, 2025

Uh oh!

btjanaka commented Nov 23, 2025

Uh oh!

btjanaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryanboldi commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

btjanaka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ryanboldi commented Nov 18, 2025 •

edited

Loading

ryanboldi commented Dec 9, 2025 •

edited

Loading