Replace .travis.yml with ci-build.yml #269#270
Merged
kevinphippsstfc merged 13 commits intomasterfrom May 19, 2022
Merged
Conversation
2 tasks
Change ICAT Ansible host references to use underscores
Remove existing MySQL installation on GitHub Actions for ICAT Ansible
Contributor
|
The Actions workflow on this branch will pass if #268 and #275 are merged in first. I have tested this by merging those two branches with this one at https://github.com/icatproject/icat.server/tree/mr-actions-test-results-test. The latest run for that branch (https://github.com/icatproject/icat.server/actions/runs/2338387038) does pass. |
MRichards99
approved these changes
May 18, 2022
Contributor
MRichards99
left a comment
MRichards99
left a comment
There was a problem hiding this comment.
Looks good, I have made an additional commit to ensure that integration test failures make the workflow run also fail. See my latest comment on the PR for how this should be merged in with the smallest amount of hassle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to GHA from Travis.
Currently failing due to #264 / #268 (and #273 / #275 may also cause failures).
Closes #269