261 datapublications for investigations#271
Conversation
|
I get a large number of compile time errors when I try build that branch: This is on openSUSE Leap 15.3, my Java version is java-1_8_0-openjdk-devel-1.8.0.322-3.64.2.x86_64. Not sure what other version information would be relevant. I tried to trace down the issue checking the individual commits. The version at 51cb1fb still compiles fine. I get errors from the integration tests … … but I assume that is due to the fact that the tests are not updated with respect to the new classes in this version and thus this is expected. When I try the version at 58297db, I get the compiler errors cited above. This commit only adds |
|
Hi Rolf, Thanks for looking at this. I think the problem is because I forgot to update the icat.client version to 5.0.0-SNAPSHOT so I have just added that to this PR. Then all the new classes referenced in WSession and TestDataPublication will be available. This means that you will have to generate an icat.client 5.0.0-SNAPSHOT on the machine where you are running the tests before the tests will run correctly. To do this I think you need to build icat.server by skipping the tests and install it somewhere so that you can build an icat.client 5.0.0-SNAPSHOT from it. Then you can rebuild icat.server without skipping the tests (there may be a better way to do this!) Cheers, Kevin |
|
Yes, I believe you are right, you need an update of It will be much easier if we have the snapshots out, because then we'll have a |
src/main/java/org/icatproject/core/entity/DataPublicationType.java
Outdated
Show resolved
Hide resolved
|
There is an issue with the upgrade script for mysql that we should look into. Otherwise I had only two very minor comments. Besides the upgrade script issue, everything looks good for me and works nicely. As indicated in the other comment above, I skipped creating the update for |
|
Thanks for spotting the incorrect constraint names @RKrahl. I've corrected those and extended the other description as requested. |
RKrahl
left a comment
There was a problem hiding this comment.
As discussed above, I did not yet run the full integration test. I'll do that once on the branch that integrates all pending schema changes later. And I did not test for Oracle. Besides these limitations, I checked this and all looks good for me.
Closes #261