style: implement clippy feedback

Author: icecreammatt

src/fileio.rs

@@ -3,7 +3,7 @@ use std::fs;
 use std::fs::File;
 use std::io::Write;
 
-pub fn file_to_hyphen(name: &String) -> String {
+pub fn file_to_hyphen(name: &str) -> String {
     name.replace(['_', ' ', '.'], "-")
 }
 
@@ -22,6 +22,6 @@ pub fn write_metadata(data: &OutputMetadata) {
 
 #[test]
 fn file_to_hyphen_test() {
-    let result = file_to_hyphen(&"2022.04.06.name with space.mp4".to_string());
+    let result = file_to_hyphen("2022.04.06.name with space.mp4");
     assert_eq!(result, "2022-04-06-name-with-space-mp4");
 }

src/main.rs

@@ -4,7 +4,7 @@ use std::process;
 
 enum Flags {
     _Gif,
-    HLS,
+    Hls,
     _Metadata,
     PreviewImage,
     Thumbnails,
@@ -32,7 +32,7 @@ impl Flags {
     fn as_str(&self) -> &'static str {
         match self {
             Flags::_Gif => "gif",
-            Flags::HLS => "HLS",
+            Flags::Hls => "HLS",
             Flags::_Metadata => "metadata",
             Flags::PreviewImage => "preview_image",
             Flags::Thumbnails => "thumbs",
@@ -77,9 +77,9 @@ fn main() {
                 .takes_value(false),
         )
         .arg(
-            Arg::with_name(Flags::HLS.as_str())
+            Arg::with_name(Flags::Hls.as_str())
                 .short('h')
-                .long(Flags::HLS.as_str())
+                .long(Flags::Hls.as_str())
                 .help("Generate hls chunks")
                 .takes_value(false),
         )
@@ -107,7 +107,7 @@ fn main() {
         create_preview_image(out.file_name.clone(), path.clone());
     }
 
-    let gen_hls = matches.is_present(Flags::HLS.as_str());
+    let gen_hls = matches.is_present(Flags::Hls.as_str());
     if gen_hls {
         create_hls_encoding(out.file_name, path);
     }

src/media_info.rs

@@ -64,13 +64,12 @@ pub fn get_media_info(input: &str) -> OutputMetadata {
             metadata.duration_human = duration.duration_human();
             metadata.frame_rate = track.frame_rate.parse().unwrap();
 
-            match track.width {
-                Some(width) => metadata.width = width.parse().unwrap(),
-                None => {}
+            if let Some(width) = track.width {
+                metadata.width = width.parse().unwrap()
             }
-            match track.height {
-                Some(height) => metadata.height = height.parse().unwrap(),
-                None => {}
+
+            if let Some(height) = track.height {
+                metadata.height = height.parse().unwrap()
             }
         }
     }