Open
Conversation
…mization settings to separate modules, parameter manipulation tools to another; make fit_history and detailed metric info in HypoFitResult configurable; catch any exception due to random failure of constrained-slsqp test; cosmetics
…o use fit_recursively (and also apply some cleanups)
…o setter and warn in case of failure (e.g. for externally constructed HypoFitResult)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HypoFitResultconfigurable (less memory and disk space usage by default) and verify consistency between detailed metric info and the external metric value (where possible; not for a fit that usedDetectors-> TODO added)Analysisclass (is a replacement of nofit_hypo desirable?)Fixes #915
Fixes #913 (create a replacement issue for the randomness)
Closes #910
Fixes #827
Should at least partially address #644
In addition, #661 could be closed as not planned if this PR goes through.