Merged
Conversation
tomaskontrimas
requested changes
Oct 18, 2025
| raise ImportError( | ||
| 'The iminuit module was not imported! ' | ||
| 'This module is a requirement of the function ' | ||
| '"calculate_critical_ts_from_gamma"!') |
Collaborator
There was a problem hiding this comment.
Suggested change
| '"calculate_critical_ts_from_gamma"!') | |
| '"fit_truncated_gamma"!') |
skyllh/core/utils/analysis.py
Outdated
| eta : float, optional | ||
| vals : (n_trials,)-shaped 1D ndarray of float | ||
| eta : float | ||
| Test-statistic value at which the gamma function is truncated |
Collaborator
There was a problem hiding this comment.
Suggested change
| Test-statistic value at which the gamma function is truncated | |
| Value at which the gamma function is truncated |
skyllh/core/utils/analysis.py
Outdated
Comment on lines
168
to
172
Collaborator
There was a problem hiding this comment.
ah, not sure if the suggestion worked out. I'd remove this check here, because it is already in the function
tomaskontrimas
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function to fit a truncated gamma function to a set of values.
It is used by functions that fit this function to the distribution of TS values for various purposes.
The arguments of the function have generic names, as it could potentially be used to fit observables other than the TS.