Skip to content

Fix #247 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomaskontrimas merged 2 commits into from
Jan 23, 2026
+5 −2
Merged

Fix #247 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eaca72
Fix #247
chiarabellenghi Jan 23, 2026
0b7659f
Fix incompatibility with Sphinx >=9.0: Config.read() TypeError during…
tomaskontrimas Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/sphinx/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
-r ../../requirements.txt
sphinx
# NOTE: Sphinx v9.0.0 introduced several breaking changes, including
# incompatibility with Sphinx multiversion project, see:
# https://github.com/sphinx-contrib/multiversion/issues/201
sphinx<9.0.0
sphinx_rtd_theme
nbsphinx
ipython
Expand Down
2 changes: 1 addition & 1 deletion skyllh/core/utils/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def pointlikesource_to_data_field_array(


def calculate_pval_from_trials(
ts_vals, ts_threshold, comp_operator='greater'):
ts_vals, ts_threshold, comp_operator='greater_equal'):
"""Calculates the percentage (p-value) of test-statistic trials that are
above the given test-statistic critical value.
In addition it calculates the standard deviation of the p-value assuming
Expand Down