Claude AI: Part 2: Convert Web .js files to .ts#360
Draft
klondikemarlen wants to merge 23 commits intomainfrom
Draft
Claude AI: Part 2: Convert Web .js files to .ts#360klondikemarlen wants to merge 23 commits intomainfrom
klondikemarlen wants to merge 23 commits intomainfrom
Conversation
klondikemarlen
added
the
refactor
klondikemarlen
force-pushed
the
claude/migrate-apis-typescript-01MXFpL2jAFbFBu5DXuJETBz
branch
from
dc018a1 to
1ab4ab5
Compare
klondikemarlen
force-pushed
the
claude/migrate-apis-typescript-01MXFpL2jAFbFBu5DXuJETBz
branch
from
1ab4ab5 to
53ddf56
Compare
…ofiles. Standardize response to include appropriate reference serializers.
Add TravelDeskHotelAsIndex type to match backend IndexSerializer pattern. Update list() return type to use AsIndex type for better type safety.
Add TravelDeskOtherTransportationAsIndex type to match backend IndexSerializer pattern. Update list() return type to use AsIndex type for better type safety.
Add TravelDeskRentalCarAsIndex type to match backend IndexSerializer pattern. Update list() return type to use AsIndex type for better type safety.
klondikemarlen
force-pushed
the
claude/migrate-apis-typescript-01MXFpL2jAFbFBu5DXuJETBz
branch
from
c01eaf3 to
eeebaf8
Compare
Convention should be "AsXYZ"
…ubmissions-api Add TravelAuthorizationPreApprovalSubmissionAsIndex and AsShow types to match controller's index and show routes which include nested associations. - AsIndex includes preApprovals with profiles - AsShow includes documents and preApprovals with profiles - Use TravelAuthorizationPreApprovalAsReference for nested preApprovals - Define TravelAuthorizationPreApprovalDocument type for documents association
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Context
We have a lot of plain .js code in the front-end. If we convert it all to TypeScript, it will make the migration from Vue 2 to Vue 3 much easier.
I'm getting Claude Code to do the conversions, and then I'll review each one and make sure it is up to standard.
Implementation
Screenshots
N/a.
Testing Instructions
dev test(ordev test_api)dev up