Conversation
NOTE: not all commands will work in this repo.
… creating Burial.Source table.
…re creating Security.User table.
…re creating AirCrash.AirCrash table.
…reating Boat.Boat table.
…ist before creating InterpretiveSite.Assets table.
… creating Person.History table.
…creating Place.Place table.
…reating YHIS.MapSheetLookup table.
Probably database field should default to GetUtcDate() rather than requiring this to be set manaully.
Why? https://docs.npmjs.com/cli/v11/configuring-npm/package-lock-json > This file is intended to be committed into source repositories
Why? So I can use relative paths for imports when running ts-node via npm.
Why? Easier to maintain in a single location.
Example: dev migrate up dev migrate make create-some-table etc.
NOTE: you need places to be able to create places as NTSMapSheet - required for creation of places - is actually a list of values taken from existing places.
Member
|
PR is not a full impl, but mergeing anyways to move on |
burkkyy
deleted the
issue-39/add-ability-for-current-user-viewing-a-place-to-see-their-current-proposed-edits-to-said-place
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Context
When a user views a place, and then proposes some changes, these changes are stored as a "proposed edit" in the "place edit?" table.
When the user goes back to view the place again, and make more changes - before the previous changes have been approved - they want to be able to add see their currently proposed edits as though they have been applied.
i.e. users want the ability to perform multiple edits over a few days, and have them bundled so they can be approved all at once.
Implementation
TODO
Screenshots
TODO
Testing Instructions
dev test(ordev test_api)dev up