Skip to content

Improve Error Message about Self-Referential Types #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InsertCreativityHere wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve Error Message about Self-Referential Types #727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ace7a6
Improve error message about self-referential types.
InsertCreativityHere Feb 12, 2026
e8a503c
Try to fix CI.
InsertCreativityHere Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slicec/src/diagnostics/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ implement_diagnostic_functions!(
(
"E047",
InfiniteSizeCycle,
format!("self-referential type {type_id} has infinite size: {cycle}"),
format!("disallowed type cycle; type {type_id} references itself: {cycle}"),
Copy link
Member

@bernardnormier bernardnormier Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a clearer error message, for example:

type {type_id} cannot reference itself: {cycle}

Copy link
Member Author

@InsertCreativityHere InsertCreativityHere Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about: type {type_id} illegally references itself: {cycle}?

type_id, cycle
),
(
Expand Down
Loading