Skip to content

[bug fix] remove incorrect passing of "no orbital parameters set" string to "readable_granule_name"#712

Merged
JessicaS11 merged 6 commits intodevelopmentfrom
cycles
Nov 13, 2025
Merged

[bug fix] remove incorrect passing of "no orbital parameters set" string to "readable_granule_name"#712
JessicaS11 merged 6 commits intodevelopmentfrom
cycles

Conversation

@JessicaS11
Copy link
Copy Markdown
Member

#704 identified a bug introduced during the transition to Harmony (#657) that caused the string "no orbital parameters set" to be passed to CMR as part of the "readable_granule_name", resulting in queries with no results returned. This mitigates that issue and adds a test for using query with the tracks parameter set.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2025

Binder 👈 Launch a binder notebook on this branch for commit d084bff

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit a5b39c2

Binder 👈 Launch a binder notebook on this branch for commit 9aa560d

@JessicaS11
Copy link
Copy Markdown
Member Author

@tsnow03 @rohaizharis Are either of you available to review this PR?

@JessicaS11 JessicaS11 linked an issue Oct 10, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.51%. Comparing base (655d67b) to head (9aa560d).
⚠️ Report is 11 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/query.py 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           development     #712       +/-   ##
================================================
+ Coverage        65.65%   76.51%   +10.86%     
================================================
  Files               37       42        +5     
  Lines             3051     3202      +151     
  Branches           396      402        +6     
================================================
+ Hits              2003     2450      +447     
+ Misses             971      615      -356     
- Partials            77      137       +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JessicaS11 JessicaS11 merged commit 819174d into development Nov 13, 2025
10 of 11 checks passed
@JessicaS11 JessicaS11 deleted the cycles branch November 13, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query with Icepyx

1 participant