Updating earthaccess and fixing a few minor bugs.#715
Updating earthaccess and fixing a few minor bugs.#715JessicaS11 merged 8 commits intoicesat2py:developmentfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I will automatically update this comment whenever this PR is modified
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #715 +/- ##
===============================================
+ Coverage 65.80% 65.83% +0.03%
===============================================
Files 37 37
Lines 3047 3050 +3
Branches 394 394
===============================================
+ Hits 2005 2008 +3
Misses 971 971
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Any idea what precommit is changing here (and why it wasn't done in the PR that updated these figures, #716?)
pyproject.toml
Outdated
| name = "icepyx" | ||
| description = "Python tools for obtaining and working with ICESat-2 data" | ||
| license = {file = "LICENSE"} | ||
| license = { file = "LICENSE" } |
There was a problem hiding this comment.
any idea what's causing the reformatting? I don't know enough about how local settings can cause changes (vs what's in the icepyx precommit config file) to figure out if somehow this file hasn't been linted before or if it was linted on your fork with different settings.
JessicaS11
left a comment
There was a problem hiding this comment.
Thanks for the updates, Luis!
|
@betolink any idea why the integration tests can't authenticate? the permissions check is passing, but then it looks like the authentication itself is failing. |
|
I think it's the same as before, the PR is coming from a fork and the action (from my fork) can't read the secrets to run the tests. Last time I copied the work from my fork to a local branch. I think once merged this should work. |
Yeah, I wondered about that. But (a) you have write permissions; (b) I was triggering the run manually and the action run log shows that I have permission: So I would expect that there's access to the secrets. It makes it so confusing. |
No description provided.