Skip to content

Updating earthaccess and fixing a few minor bugs.#715

Merged
JessicaS11 merged 8 commits intoicesat2py:developmentfrom
betolink:webinar
Nov 14, 2025
Merged

Updating earthaccess and fixing a few minor bugs.#715
JessicaS11 merged 8 commits intoicesat2py:developmentfrom
betolink:webinar

Conversation

@betolink
Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2025

Binder 👈 Launch a binder notebook on this branch for commit 9090abc

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 5016a38

Binder 👈 Launch a binder notebook on this branch for commit c8451c8

Binder 👈 Launch a binder notebook on this branch for commit 114342b

Binder 👈 Launch a binder notebook on this branch for commit 8ba95dc

Binder 👈 Launch a binder notebook on this branch for commit 7a0cf83

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.83%. Comparing base (819174d) to head (7a0cf83).
⚠️ Report is 10 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/orders.py 0.00% 1 Missing ⚠️
icepyx/core/read.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #715      +/-   ##
===============================================
+ Coverage        65.80%   65.83%   +0.03%     
===============================================
  Files               37       37              
  Lines             3047     3050       +3     
  Branches           394      394              
===============================================
+ Hits              2005     2008       +3     
  Misses             971      971              
  Partials            71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@betolink betolink marked this pull request as ready for review October 21, 2025 03:00
@betolink betolink changed the title [DNM] Updating earthaccess and fixing a few minor bugs. Updating earthaccess and fixing a few minor bugs. Oct 21, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what precommit is changing here (and why it wasn't done in the PR that updated these figures, #716?)

pyproject.toml Outdated
name = "icepyx"
description = "Python tools for obtaining and working with ICESat-2 data"
license = {file = "LICENSE"}
license = { file = "LICENSE" }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea what's causing the reformatting? I don't know enough about how local settings can cause changes (vs what's in the icepyx precommit config file) to figure out if somehow this file hasn't been linted before or if it was linted on your fork with different settings.

Copy link
Copy Markdown
Member

@JessicaS11 JessicaS11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, Luis!

@JessicaS11
Copy link
Copy Markdown
Member

@betolink any idea why the integration tests can't authenticate? the permissions check is passing, but then it looks like the authentication itself is failing.

@betolink
Copy link
Copy Markdown
Contributor Author

I think it's the same as before, the PR is coming from a fork and the action (from my fork) can't read the secrets to run the tests. Last time I copied the work from my fork to a local branch. I think once merged this should work.

@JessicaS11
Copy link
Copy Markdown
Member

I think it's the same as before, the PR is coming from a fork and the action (from my fork) can't read the secrets to run the tests. Last time I copied the work from my fork to a local branch. I think once merged this should work.

Yeah, I wondered about that. But (a) you have write permissions; (b) I was triggering the run manually and the action run log shows that I have permission:
[Action Query] The user: JessicaS11 permission is admin.
[Action Require] The JessicaS11 permission check is true.

So I would expect that there's access to the secrets. It makes it so confusing.

@JessicaS11 JessicaS11 merged commit a548974 into icesat2py:development Nov 14, 2025
8 of 14 checks passed
@JessicaS11 JessicaS11 linked an issue Nov 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2 Harmony] read tutorial needs updating

2 participants