fix download function to order granules if needed#726
Merged
JessicaS11 merged 3 commits intodevelopmentfrom Dec 11, 2025
Merged
fix download function to order granules if needed#726JessicaS11 merged 3 commits intodevelopmentfrom
JessicaS11 merged 3 commits intodevelopmentfrom
Conversation
betolink
approved these changes
Dec 4, 2025
| # are no job IDs registered by the harmony API | ||
| if hasattr(self, "last_order") is None: | ||
| raise ValueError("No order has been placed yet.") | ||
| if not hasattr(self, "last_order"): |
Contributor
There was a problem hiding this comment.
makes sense, I probably used the exception due my lack of familiarity with what most users were expecting here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #726 +/- ##
============================================
Coverage 65.83% 65.83%
============================================
Files 37 37
Lines 3050 3050
Branches 394 394
============================================
Hits 2008 2008
Misses 971 971
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks @betolink! The fact that for some reason the status isn't being reported properly aside, the unit tests are failing. It looks like, despite the version number being explicitly passed as "6", version 7 granules are being returned. Any idea why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several users (#666, #720) have reported issues with receiving errors when attempting to download data without first running
order_granules(), a known issue documented in #688 and #699. This PR updates the download function to first order data if the user has not explicitly run the order function, returning to the intended behavior of icepyx in v1.