Skip to content

Update issue templates#728

Merged
JessicaS11 merged 12 commits intodevelopmentfrom
issue-templates
Dec 17, 2025
Merged

Update issue templates#728
JessicaS11 merged 12 commits intodevelopmentfrom
issue-templates

Conversation

@JessicaS11
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 5, 2025

Binder 👈 Launch a binder notebook on this branch for commit 9de6ac2

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit bdd0219

Binder 👈 Launch a binder notebook on this branch for commit 57c71a5

Binder 👈 Launch a binder notebook on this branch for commit a0d0c12

Binder 👈 Launch a binder notebook on this branch for commit 0dfeea6

Binder 👈 Launch a binder notebook on this branch for commit 739eac3

Binder 👈 Launch a binder notebook on this branch for commit dcea109

Binder 👈 Launch a binder notebook on this branch for commit 989642a

Binder 👈 Launch a binder notebook on this branch for commit f945fd9

Binder 👈 Launch a binder notebook on this branch for commit d95058b

Binder 👈 Launch a binder notebook on this branch for commit cd8d176

Binder 👈 Launch a binder notebook on this branch for commit 53e29f6

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.83%. Comparing base (7251f19) to head (53e29f6).
⚠️ Report is 11 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #728   +/-   ##
============================================
  Coverage        65.83%   65.83%           
============================================
  Files               37       37           
  Lines             3050     3050           
  Branches           394      394           
============================================
  Hits              2008     2008           
  Misses             971      971           
  Partials            71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rwegener2
Copy link
Copy Markdown
Contributor

rwegener2 commented Dec 11, 2025

I just updated these to be more tailored to icepyx! Changes:

  • feature request template: I didn’t change much other than inserting “icepyx” where the template said “our project”
  • bug report template: I switched to yaml because I wanted to add a bit of new functionality (Ex. having a place where a user could include a code block; specify placeholder text; …)

Ready for review. I just requested @asteiker (@JessicaS11 I can’t request you, I assume because you opened the initial PR).

@JessicaS11 do you have any insight on the failing integration check? The error is User **pre-commit-ci[bot]** does not have permission to run integration tests and it looks like it’s a required check.

@rwegener2 rwegener2 requested a review from asteiker December 11, 2025 17:09
@JessicaS11
Copy link
Copy Markdown
Member Author

do you have any insight on the failing integration check? The error is User pre-commit-ci[bot] does not have permission to run integration tests and it looks like it’s a required check.

That one is when precommit runs and thus the last commit is from the bot, it doesn't have access to the secrets required for the integration tests. I'm not sure if there's an easy way to fix that. Either way, the integration tests will still fail because I just updated them for v007 file IDs and sizes (#727), but for some reason v006 granules are being returned now (versus last week when I first updated them). I'm working with NSIDC on it.

Copy link
Copy Markdown
Collaborator

@asteiker asteiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwegener2 These are great additions! I don't have any suggestions in terms of the content, though I pasted in the errors that I received when I viewed the file within GitHub. I don't have time atm to suggest updates other than posting those messages, but happy to look into this after AGU (though I admit I don't have any experience with these).

@@ -0,0 +1,96 @@
name: Bug Report
description: Create a report about an error to help us improve
title: ""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I went to view the file, several problems were listed at the top. Copying them into each relevant section:

title must be of type String and cannot be empty. Learn more about error 1.

title: ""
labels: ""
projects: ""
assignees: ""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed when I went to View File:

assignees must be of type String or Array. Learn more about error 2.

name: Bug Report
description: Create a report about an error to help us improve
title: ""
labels: ""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labels must be of type String or Array. Learn more about error 3.

description: Create a report about an error to help us improve
title: ""
labels: ""
projects: ""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects must be of type String or Array. Learn more about error 4.

@rwegener2
Copy link
Copy Markdown
Contributor

rwegener2 commented Dec 15, 2025

… though I pasted in the errors that I received when I viewed the file within GitHub

Thanks so much @asteiker, this is really helpful!

Where did you go to see those error messages? I don’t think I’m seeing them when I just open the file in the “Files Changed” section of the PR Nevermind, I found it by viewing the file in the issue-templates branch. Thanks for pointing that out, I didn’t realize you could do that! I’ll go through and fix those syntax errors.

Comment on lines +10 to +12
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the input format consistent (i.e. make these input boxes as well, where presumably the instructions are temporary text or separate from the response without the user manually deleting)?

@JessicaS11
Copy link
Copy Markdown
Member Author

This looks great, @rwegener2! Thank you! I added a few minor formatting notes, but happy for you to approve and merge this PR whenever.

@rwegener2 rwegener2 self-requested a review December 15, 2025 21:34
@rwegener2
Copy link
Copy Markdown
Contributor

Thanks for the review @JessicaS11! I updated the templated addressing your comments.

I actually am not allowed to squash and merge, I think because the Integration Test is marked a a required test. Is there a work-around for that?

@asteiker
Copy link
Copy Markdown
Collaborator

@rwegener2 Sorry for missing your question on viewing the files and associated warnings! Glad you found it. Yes I was also able to do this from the PR by clicking on Files Changed tab and clicking the three dots at the top of the file -> View file.

@JessicaS11
Copy link
Copy Markdown
Member Author

I actually am not allowed to squash and merge, I think because the Integration Test is marked a a required test. Is there a work-around for that?

I use my admin privileges to check the box allowing us to bypass the rules... not my favorite to use, but until we get them debugged/fixed...

@JessicaS11 JessicaS11 merged commit 3255483 into development Dec 17, 2025
10 of 11 checks passed
@JessicaS11 JessicaS11 deleted the issue-templates branch December 17, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants