Conversation
|
I will automatically update this comment whenever this PR is modified
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #728 +/- ##
============================================
Coverage 65.83% 65.83%
============================================
Files 37 37
Lines 3050 3050
Branches 394 394
============================================
Hits 2008 2008
Misses 971 971
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I just updated these to be more tailored to icepyx! Changes:
Ready for review. I just requested @asteiker (@JessicaS11 I can’t request you, I assume because you opened the initial PR). @JessicaS11 do you have any insight on the failing integration check? The error is |
for more information, see https://pre-commit.ci
That one is when precommit runs and thus the last commit is from the bot, it doesn't have access to the secrets required for the integration tests. I'm not sure if there's an easy way to fix that. Either way, the integration tests will still fail because I just updated them for v007 file IDs and sizes (#727), but for some reason v006 granules are being returned now (versus last week when I first updated them). I'm working with NSIDC on it. |
asteiker
left a comment
There was a problem hiding this comment.
@rwegener2 These are great additions! I don't have any suggestions in terms of the content, though I pasted in the errors that I received when I viewed the file within GitHub. I don't have time atm to suggest updates other than posting those messages, but happy to look into this after AGU (though I admit I don't have any experience with these).
| @@ -0,0 +1,96 @@ | |||
| name: Bug Report | |||
| description: Create a report about an error to help us improve | |||
| title: "" | |||
There was a problem hiding this comment.
When I went to view the file, several problems were listed at the top. Copying them into each relevant section:
title must be of type String and cannot be empty. Learn more about error 1.
| title: "" | ||
| labels: "" | ||
| projects: "" | ||
| assignees: "" |
There was a problem hiding this comment.
Listed when I went to View File:
assignees must be of type String or Array. Learn more about error 2.
| name: Bug Report | ||
| description: Create a report about an error to help us improve | ||
| title: "" | ||
| labels: "" |
There was a problem hiding this comment.
labels must be of type String or Array. Learn more about error 3.
| description: Create a report about an error to help us improve | ||
| title: "" | ||
| labels: "" | ||
| projects: "" |
There was a problem hiding this comment.
projects must be of type String or Array. Learn more about error 4.
Thanks so much @asteiker, this is really helpful!
|
| **Is your feature request related to a problem? Please describe.** | ||
| A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
|
There was a problem hiding this comment.
Should we make the input format consistent (i.e. make these input boxes as well, where presumably the instructions are temporary text or separate from the response without the user manually deleting)?
|
This looks great, @rwegener2! Thank you! I added a few minor formatting notes, but happy for you to approve and merge this PR whenever. |
Co-authored-by: Jessica Scheick <JessicaS11@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Thanks for the review @JessicaS11! I updated the templated addressing your comments. I actually am not allowed to squash and merge, I think because the Integration Test is marked a a required test. Is there a work-around for that? |
|
@rwegener2 Sorry for missing your question on viewing the files and associated warnings! Glad you found it. Yes I was also able to do this from the PR by clicking on Files Changed tab and clicking the three dots at the top of the file -> View file. |
I use my admin privileges to check the box allowing us to bypass the rules... not my favorite to use, but until we get them debugged/fixed... |
No description provided.