[WIP][Sprint 25/26/ PD-475] - Extended Kalman Filter for Landmarks Position #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borednuna
reviewed
Dec 18, 2025
|
|
||
| projected_ball.position.x = X[0][0]; | ||
| projected_ball.position.y = X[1][0]; | ||
|
|
There was a problem hiding this comment.
Move these logic codes to separate cpp files. Cpp files inside node directory should only contain the node configuration itself (publisher-subscriber). Can refer to akushon, ninshiki_cpp, or other packages as well.
mbsaloka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/browse/PD-475
Description
Describe problems, if any, clearly and concisely.
Describe any changes that have been made in this pull request.
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)