[Enhancement] Set Blob Size Based On YOLO Config #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbsaloka
changed the title
borednuna
approved these changes
Jul 13, 2024
FaaizHaikal
reviewed
Jul 14, 2024
Comment on lines
51
to
58
| while (std::getline(ifs_cfg, cfg_line)) { | ||
| if (cfg_line.find("width") != std::string::npos) { | ||
| width = std::stoi(jitsuyo::split_string(cfg_line, "=")); | ||
| } else if (cfg_line.find("height") != std::string::npos) { | ||
| height = std::stoi(jitsuyo::split_string(cfg_line, "=")); | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This loop assumes that width is always above height in the cfg. You can do something like this in case the cfg is written otherwise:
Suggested change
| while (std::getline(ifs_cfg, cfg_line)) { | |
| if (cfg_line.find("width") != std::string::npos) { | |
| width = std::stoi(jitsuyo::split_string(cfg_line, "=")); | |
| } else if (cfg_line.find("height") != std::string::npos) { | |
| height = std::stoi(jitsuyo::split_string(cfg_line, "=")); | |
| break; | |
| } | |
| } | |
| int flag = 0; | |
| while (std::getline(ifs_cfg, cfg_line)) { | |
| if (flag >= 2) break; | |
| if (cfg_line.find("width") != std::string::npos) { | |
| width = std::stoi(jitsuyo::split_string(cfg_line, "=")); | |
| flag++; | |
| } else if (cfg_line.find("height") != std::string::npos) { | |
| height = std::stoi(jitsuyo::split_string(cfg_line, "=")); | |
| flag++; | |
| } | |
| } |
Member
There was a problem hiding this comment.
if (height != 0 && width != 0) {
break;
}instead of flag, what about this?
Contributor
There was a problem hiding this comment.
ow yeah, that's better
FaaizHaikal
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
Description
Set blob size based on width and height on yolo config
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)