[PI Sprint 24/25 / PD-462] - [Feature] Migrate to RoslibJS#26
Merged
FaaizHaikal merged 3 commits intomasterfrom Mar 15, 2025
Merged
[PI Sprint 24/25 / PD-462] - [Feature] Migrate to RoslibJS#26FaaizHaikal merged 3 commits intomasterfrom
FaaizHaikal merged 3 commits intomasterfrom
Conversation
FaaizHaikal
reviewed
Mar 8, 2025
Comment on lines
52
to
69
| nlohmann::json config; | ||
| try { | ||
| config = nlohmann::json::parse(request->json_color); | ||
| jitsuyo::save_config(path, "color_classifier.json", config); | ||
|
|
||
| response->success = true; | ||
| } catch (const std::exception & e) { | ||
| RCLCPP_ERROR(node->get_logger(), "Exception occurred: %s", e.what()); | ||
| response->success = false; | ||
| return; | ||
| } | ||
|
|
||
| if (!jitsuyo::save_config(path, "color_classifier.json", config)) { | ||
| response->success = false; | ||
| return; | ||
| } | ||
|
|
||
| response->success = true; |
Contributor
There was a problem hiding this comment.
Suggested change
| nlohmann::json config; | |
| try { | |
| config = nlohmann::json::parse(request->json_color); | |
| jitsuyo::save_config(path, "color_classifier.json", config); | |
| response->success = true; | |
| } catch (const std::exception & e) { | |
| RCLCPP_ERROR(node->get_logger(), "Exception occurred: %s", e.what()); | |
| response->success = false; | |
| return; | |
| } | |
| if (!jitsuyo::save_config(path, "color_classifier.json", config)) { | |
| response->success = false; | |
| return; | |
| } | |
| response->success = true; | |
| nlohmann::json config; | |
| try { | |
| config = nlohmann::json::parse(request->json_color); | |
| } catch (const std::exception & e) { | |
| RCLCPP_ERROR(node->get_logger(), "Exception occurred: %s", e.what()); | |
| response->success = false; | |
| return; | |
| } | |
| if (!jitsuyo::save_config(path, "color_classifier.json", config)) { | |
| response->success = false; | |
| return; | |
| } | |
| response->success = true; |
Mobilizes
approved these changes
Mar 9, 2025
FaaizHaikal
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/browse/PD-462
Description
Remove gRPC and create config_node for capture setting config service
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)