[PI Sprint 25/26] [Feature] - Add LAB Color Classification #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaaizHaikal
requested changes
Dec 15, 2025
src/ninshiki_cpp/utils/color.cpp
Outdated
Comment on lines
29
to
43
| const std::string & name, | ||
| bool invert_hue, | ||
| bool use_lab, | ||
| int min_hue, | ||
| int max_hue, | ||
| int min_saturation, | ||
| int max_saturation, | ||
| int min_value, | ||
| int max_value, | ||
| int min_lightness, | ||
| int max_lightness, | ||
| int min_a, | ||
| int max_a, | ||
| int min_b, | ||
| int max_b) |
Contributor
There was a problem hiding this comment.
Too high cognitive complexity, i suggest create a ColorConfig struct
FaaizHaikal
approved these changes
Dec 18, 2025
shikajiko
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/browse/PD-482
Description
Add LAB color classification, better for outdoor color detection.
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)