Added geadd, tzadd, tests for device utility functions#124
Merged
tdehoff merged 10 commits intoicl-utk-edu:masterfrom Sep 8, 2025
Merged
Added geadd, tzadd, tests for device utility functions#124tdehoff merged 10 commits intoicl-utk-edu:masterfrom
tdehoff merged 10 commits intoicl-utk-edu:masterfrom
Conversation
WestonJB
force-pushed
the
device_add
branch
2 times, most recently
from
d1d1747 to
c5ed9d3
Compare
tdehoff
requested changes
Aug 24, 2025
Contributor
tdehoff
left a comment
tdehoff
left a comment
There was a problem hiding this comment.
Overall, everything looks good to me. Minor note: your comments should end with a period or start with a lowercase letter.
mgates3
approved these changes
Sep 5, 2025
Collaborator
mgates3
left a comment
mgates3
left a comment
There was a problem hiding this comment.
I fixed all these changes.
…all enum values are handled.
mgates3
reviewed
Sep 6, 2025
tdehoff
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
--aux-deviceoption to test/run_tests.py which tests conj, geadd, and tzadd device rountines.