Various Components: Avoid Mixed Memory Allocation#382
Merged
Treece-Burgess merged 1 commit intoicl-utk-edu:masterfrom Jun 2, 2025
Merged
Conversation
3 tasks
|
I am testing this PR. |
3 tasks
4851aa9 to
4538ef4
Compare
tokey-tahmid
approved these changes
May 29, 2025
tokey-tahmid
left a comment
There was a problem hiding this comment.
Tested on Oregon's Gilgamesh (AMD EPYC 7413, 1 * H100, 2 * MI200) with CUDA toolkit 12.8 and ROCM 6.4.0
All PAPI utilities and tests perform as expected.
…ation to avoid possible segmentation faults.
4538ef4 to
8837701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR addresses components mixing C memory allocation and PAPI memory allocation. This becomes an issue when you add the flag
--with-debug=memoryas:papi_freea variable that was allocated with justmalloc,calloc, orreallocwill result in a segmentation faultBelow are Components that have changes done to them:
rocm_smipapi_component_avail- ✅*
papi_native_avail- ✅*
papi_command_line- ✅*Application Code with
PAPI_shutdown- ✅rocmpapi_component_avail- ✅*
papi_native_avail- ✅*
papi_command_line- ✅*Application Code with
PAPI_shutdown- ✅coretemppapi_component_avail- ✅*
papi_native_avail- ✅*
papi_command_line- ✅*Application Code with
PAPI_shutdown- ✅cudapapi_component_avail- ✅*
papi_native_avail- ✅*
papi_command_line- ✅*Application Code with
PAPI_shutdown- ✅infinibandpapi_component_avail- ✅*
papi_native_avail- ✅*
papi_command_line- ✅*Application Code with
PAPI_shutdown- ✅Note that the Cuda component did not change to PAPI memory allocation as when testing the runtime was extremely long in
--with-debug=memoryto the point the utilities looked like they hang.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests