Open
Conversation
dbarry9
added
component-sde
dbarry9
force-pushed
the
2026.01.23_sde-gitignore
branch
2 times, most recently
from
74ebf78 to
5dc5f3d
Compare
This file was being used a placeholder so that the sde/tests/lib subdirectory would exist. For the sake of cleanliness in releases, these changes replace this file with a Makefile target to create and remove the lib subdirectory, as appropriate. These changes have been tested on the Frontier supercomputer, which contains the AMD Zen3 architecture.
dbarry9
force-pushed
the
2026.01.23_sde-gitignore
branch
from
5dc5f3d to
9aba6f0
Compare
Contributor
|
I am reviewing this PR. |
Treece-Burgess
requested changes
Jan 29, 2026
|
|
||
| create_dir: lib | ||
|
|
||
| lib: |
Contributor
There was a problem hiding this comment.
nit: I would add a similar line break as the other targets i.e.
###############################################################################
## Create lib directory
.
.
.
| sde_tests: $(TESTS) | ||
| sde_tests: create_dir $(TESTS) | ||
|
|
||
| create_dir: lib |
Contributor
There was a problem hiding this comment.
Q: Why the intermediate create_dir? You can just pass the target lib directly to sde_tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Remove unused file from
src/components/sde.These changes have been tested on the Frontier supercomputer, which contains the AMD Zen3 architecture. The PAPI utilities (
papi_avail,papi_native_avail,papi_component_avail,papi_hardware_avail, andpapi_mem_info) function properly, and all of thesdecomponent tests pass.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests