add function based constructor for band matrix and insertLocalTiles

[jamabr]

After some time, I started to synchronize our code to the recent SLATE developments. I was happy to see the progress, which made some of our local adjustments deprecated. For band matrices we require the function based constructor and the insertLocalTiles function. Is this of interest for upstream?

[mgates3]

This looks helpful. I'll look it over. Are there any tests / unit tests that use the new constructor? That would help assure that it is correct.

[jamabr]

This looks helpful. I'll look it over. Are there any tests / unit tests that use the new constructor? That would help assure that it is correct.

Not yet, but I can check how you have implemented the tests for the others and add...

[mgates3]

See slate/unit_test/test_BandMatrix.cc and compare slate/unit_test/test_Matrix.cc. The GitHub CT runs:

slate/unit_test> ./run_tests.py test_BandMatrix

Well, the CT runs the whole unit test suite. That command runs the relevant part of the suite.

[jamabr]

Thanks for pointing me to this, I will add a similar test the next days...

[jamabr]

I added a test for the constructor and the new functions, similar to the tests you pointed to from the Matrix class.
Edit: Unfortunately I am not able to identify why the check fails...