Symmetric and Hermatian Matrix: Let ´slice´ automatically select the data from the available triangle#215
Draft
jamabr wants to merge 1 commit intoicl-utk-edu:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user might not want to think about which triangle contains the data when requesting a slice from a
SymmetricMatrixofHermitianMatrix. Therefore, the updatedslicefunctions returns the requested slice in any case, if required, the transposed version of the existing slice is returned.For our code this is really helpful.
In case of interest for upstream, I can check whether the test can be reasonably updated...