Open
Conversation
|
The following package files were changed: (Review: flagged files) |
…ation/open-brush into feature/quill-import
Moved the new properties out of QuillTubeBrush and up into TubeBrush. Since they are called as part of the tube brush logic we might as well expose them for everybody. The Quill brushes are now mostly specialized in the prefabs rather than the code. Added 90° extra offset to cube, cylinder and ellipse. Switched axis of ellipse minor axis. Ellipse modifier: allow scale to be above 1.0 and switch axis if so.
…ween control points.
…lt when moving the property to the prefab.
…e to the correct knot. We were using the m_Displacements array without taking into account the fact that vertices are shared between knots. So for the first part of the chunk of vertices controlled by a knot we were using the displacement relative to the wrong knot. Due to the overlap we also don't need to go through all vertices of each knot, only the second half.
…ntation basis at each control point. Use the one matching Quill importer. Changed variables names that were based on Blender axes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.