Removes unused variables from Icosa code #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The pseudo-lint is run by CI, so it should be run before committing locally. There is no git-native way to check hooks into a project. This does add a set to setup, but other setup actions can and should be moved to the setup script over time.
Why: The format for fread should be a string: https://www.erlang.org/doc/apps/stdlib/io.html#fread/2 It will accept a charlist, but some versions of `mix format` flag that as an error.
…ixir and OTP Why: This may detect some changes in Elixir that our old code must change to match.
Why: A commit shouldn't have to fix problems unrelated to its main purpose.
What: Changes the format string that is passed to the io_lib.fread function from a binary/UTF-8 encoded string back to a character list, but uses the character list sigil syntax, rather than single quotes, to make `mix format` happy. Why: Hubs Compose throws errors when io_lib.fread is passed a binary/UTF-8 encoded string, rather than a character list. Notes: Community Edition instances don't have any issues with the format string being a binary/UTF-8 encoded string, so potentially the issue with Hubs Compose is because Hubs Compose uses the dev build stage in the Reticulum Dockerfile. This commit relates to: a86014d From what I can tell the `string` io_lib.fread is looking for is synonymous with a character list. References: https://www.erlang.org/doc/apps/stdlib/io_lib.html#fread/2 https://www.erlang.org/doc/apps/erts/erlang#t:string/0 https://www.erlang.org/doc/apps/erts/erlang#t:binary/0 https://stackoverflow.com/questions/18756293/elixir-io-lib-call-to-erlang https://stackoverflow.com/questions/29567049/elixir-calling-io-lib-fread
removes Mozilla branding in spoke-preview.png test.glb is just a cube with no visual branding I don't think any of the devops files are actually used, but that's a different pull request. We might want to use a placeholder identifies instead of Hubs Foundation. Content should now appear on the What's New page (for example, https://demo.hubsfoundation.org/whats-new) according to what PRs have been merged, rather that what's new on this server. It appears index.html.eex is nowhere used. Some identifiers containing "mozilla" could not be changed, as they cause the automated tests to fail.
Why: to reduce developer confusion & number of CI warnings
|
I think the unused variable removal is good. Everything seems to test fine, and the changes look good from my limited understanding of Elixir (which was supplemented by lots of web searching and querying the phind.com AI with the PHIND-70B MODEL). One potential issue. It looks like this PR is based on PR #3 but it doesn't include the merge commit or the |
Author
|
Closed in favor of Hubs-Foundation#743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.