Clarify maximum score for problems #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
previously approved these changes
Jul 29, 2025
niemela
previously approved these changes
Aug 25, 2025
niemela
reviewed
Aug 25, 2025
This PR was started because we noticed that the problem format allows both -infinity and +infinity as maximum scores, but the Contest API doesn't allow either. After talking to Fredrik and Nicky we decided not to 'fix' this: - -infinity is being removed from the next version of the problem format. - +infinity is rarely used, and there's an easy workaround (just pick an arbitrarily high value) so we'll leave it. While discussing this we found that the max_score was poorly defined as 'this is the max, but maybe not' and decided to simplify and make it more strict. I went with just removing the weak phrase: this IS the maximum score possible. I also felt 'indicate' could be improved (went with 'determine') and 'in scoring contests' was redundant (removed it). As with anything in the spec, we'd expect servers to enforce the max_score, but encourage clients to be liberal in what they accept. e.g. currently the resolver doesn't work if you score the maximum and then have another submission, but we'll fix this.
Clarify judgement score is between 0 and the problem's max_score.
deboer-tim
dismissed stale reviews from niemela and nickygerritsen
via
35a97cb
|
Rebased commit to latest, and added 'Score for this judgement, between |
niemela
approved these changes
Aug 25, 2025
eldering
approved these changes
Aug 25, 2025
nickygerritsen
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was started because we noticed that the problem format allows both -infinity and +infinity as maximum scores, but the Contest API doesn't allow either. After talking to Fredrik and Nicky we decided not to 'fix' this:
While discussing this we found that the max_score was poorly defined as 'this is the max, but maybe not' and decided to simplify and make it more strict. I went with just removing the weak phrase: this IS the maximum score possible.
I also felt 'indicate' could be improved (went with 'determine') and 'in scoring contests' was redundant (removed it).
As with anything in the spec, we'd expect servers to enforce the max_score, but encourage clients to be liberal in what they accept. e.g. currently the resolver doesn't work if you score the maximum and then have another submission, but we'll fix this.