Skip to content

Fix rounding error when getting VisualLine #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trijnsburger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix rounding error when getting VisualLine #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ICSharpCode.AvalonEdit/Rendering/TextView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,10 +1743,12 @@ public VisualLine GetVisualLineFromVisualTop(double visualTop)
// TODO: change this method to also work outside the visible range -
// required to make GetPosition work as expected!
EnsureVisualLines();

double epsilon = 1e-12; // Small margin to prevent rounding problems, Double.Epsilon is not a large enough margin.
foreach (VisualLine vl in this.VisualLines) {
if (visualTop < vl.VisualTop)
if (visualTop < vl.VisualTop - epsilon)
continue;
if (visualTop < vl.VisualTop + vl.Height)
if (visualTop < vl.VisualTop + vl.Height - epsilon)
return vl;
}
return null;
Expand Down