Fix: Rectangular selection ignores scroll offset #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
AvaloniaEdituser has discovered a problem with rectangular selection when virtual space is enabled. See AvaloniaUI/AvaloniaEdit#472.I provided a fix for
AvaloniaEdit: AvaloniaUI/AvaloniaEdit#496AvalonEditshows the same problem. This PR implements the fix forAvalonEdit.Details:
When a selection extends beyond the visual line into the "virtual space" then the
BackgroundGeometryBuildercreates two segments per line. One for the visible text, and one for the virtual space.The segment for the virtual space didn't apply the scroll offset. This is now fixed.