Add scopes to AssignVariableName#3416
Merged
siegfriedpammer merged 6 commits intomasterfrom Mar 21, 2025
Merged
Conversation
…ming parameters of nested ILFunctions in the future.
…f they syntactically refer to the same range variable
…there are with names from outer scopes collisions.
siegfriedpammer
force-pushed
the
variable-naming
branch
from
0f35adb to
355a039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers: #1572, #1956, #2439, #2694
Needs more thorough testing on larger code bases, but it will be hard to verify the results.
@tamlin-mike @yyjdelete @greenozon
@dgrunwald I suspect that the "allow shadowing of names in local functions / lambdas" language feature could be implemented in ILSpy by making sure that no variables in the ILFunction.CapturedVariables list have the same name as any local variable or parameter? The changes in this PR only introduce the concept of a scope per ILFunction, so parameters of "independent" lambdas such as
list.Where(x => x > 5).Select(x => x * 2)are allowed even without the setting, but nested lambdas that "shadow" a lambda parameter, but don't use any variable from a parent scope are not allowed right now.