Improve generation of not equals check#3425
Merged
siegfriedpammer merged 2 commits intoicsharpcode:masterfrom Mar 22, 2025
Merged
Improve generation of not equals check#3425siegfriedpammer merged 2 commits intoicsharpcode:masterfrom
siegfriedpammer merged 2 commits intoicsharpcode:masterfrom
Conversation
428079d to
012f581
Compare
ElektroKill
commented
Mar 18, 2025
siegfriedpammer
approved these changes
Mar 22, 2025
Member
|
Thank you very much for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers:
fixes #3423
Problem
The decompiler would use
0for the!= 0check even if the type was an enum.Solution
ExpressionBuilder.ConvertConstantValueto generate the expression for the0constant