Skip to content

Conversation

@tjlaboss
Copy link
Collaborator

@tjlaboss tjlaboss commented Jan 13, 2026

Pull Request Checklist for MontePy

Description

  • Add object support for S, SX, SY, SZ, SO, similar to the cylinder and plane support.
  • Minor surface infrastructure updates

Fixes #876 (issue number)


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

LLM Disclosure

Were any large language models (LLM or "AI") used in to generate any of this code?

  • Yes
    • Model(s) used:
  • No

Documentation Checklist

  • I have documented all added classes and methods.

Additional Notes for Reviewers

Ensure that:

  • This PR fully addresses and resolves the referenced issue(s).
  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

Discussion

Spheres aren't candidates for periodic surfaces. I deleted duplicate surface checking related to that: please review carefully. There is a lot of copypasta for surface infrastructure that would be candidates for kicking up the Surface class or some other intermediate class.


📚 Documentation preview 📚: https://montepy--877.org.readthedocs.build/en/877/

@tjlaboss tjlaboss changed the title Baller Support Spheres Jan 13, 2026
@tjlaboss tjlaboss requested a review from MicahGale January 13, 2026 21:24
@tjlaboss
Copy link
Collaborator Author

I got the coverage up enough to pass, but think that .find_duplicate_surfaces() should be reevaluated in the future (#878).

@MicahGale
Copy link
Collaborator

I got the coverage up enough to pass, but think that .find_duplicate_surfaces() should be reevaluated in the future (#878).

I'm not going to merge such a big untested function. Before #878 you could just return an empty list.

Copy link
Collaborator

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be fun to merge into minor_rel_dev

Copy link
Collaborator

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes should be marked with the version the objects were added.

Also patch coverage is < 100%. I think you need to look into the validation testing some more.

@tjlaboss tjlaboss requested a review from MicahGale January 14, 2026 19:51
@tjlaboss
Copy link
Collaborator Author

Ready for re-review.

Changed in version 9.0: The versionadded directive was renamed to version-added. The previous name is retained as an alias.
@tjlaboss tjlaboss enabled auto-merge (squash) January 15, 2026 16:12
Copy link
Collaborator

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta have more coverage.

@tjlaboss tjlaboss requested a review from MicahGale January 19, 2026 16:20
@tjlaboss
Copy link
Collaborator Author

Is patch coverage 99.115% sufficient?

Copy link
Collaborator

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests, and thanks for the patience @tjlaboss, and the feature. I think we can make an acceptation to the 100% patch coverage rule here.

@tjlaboss tjlaboss merged commit 3887092 into develop Jan 19, 2026
21 checks passed
@tjlaboss tjlaboss deleted the baller branch January 19, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sphere support

3 participants