-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Recover boundary elements in zero algebraic range explicit NEML2 #32198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
7426340 to
a5eb298
Compare
|
Job Precheck, step Clang format on a5eb298 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
libmesh
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit c144a6e3ae9d721c0b780ac0035cff984c742ea1 | |||
| Subproject commit a9f56e9ed51a235edbcfecb00522389977663817 | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
a5eb298 to
610beb6
Compare
|
Job Coverage, step Generate coverage on 348fc8a wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
9cb0f3f to
f1c6794
Compare
f1c6794 to
420c8c4
Compare
420c8c4 to
a1eb364
Compare
a1eb364 to
deb2ce5
Compare
ff34e75 to
348fc8a
Compare
|
Job Test, step Results summary on 348fc8a wanted to post the following: Framework test summaryCompared against 5eee4e5 in job civet.inl.gov/job/3497366. No change Modules test summaryCompared against 5eee4e5 in job civet.inl.gov/job/3497366. No change |
|
Job Documentation, step Docs: sync website on 348fc8a wanted to post the following: View the site here This comment will be updated on new commits. |
Reason
In #30853 we introduced a capability to offload residual calculations to NEML2 for fast explicit dynamics simulations (
NEML2CentralDifference). This works by clearing the algebraic range (the list of elements initialized and processed by MOOSE). However this effectively disables calculation of integrated boundary conditions.Also, for stateful materials we should advance teh state from current -> old on device, without the roundtrip via MOOSE materials (which we added to ensure correct restepping / failed timestep rollback). We're not going to evaluate the materials with a cleared out algebraic range, and this would add substantial overhead.
Design
Use the integrated boundary condition warehouse to compile a list of all boundaries which have BCs applied. Then filter the boundary element range to get all elements touching one of those boundaries and add them back to the algebraic range.
Add an option to retain state on device to minimize communication.
Impact
Integrated BCs are available again with NEML2 residual calculation, stateful property support for
NEML2CentralDifference.