Proposed re-organization of warning & solution invalidity code #32219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defines the mooseInfo/Warning/Error so we no longer need to do "usingSolutionInvalidWarnings" in every user class refs idaholab#28181
GiudGiud
force-pushed
the
PR_solu_inva
branch
from
93beb11 to
814723f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #28181
The intent here is to have mooseWarning default to recording warnings through the (previously-named) solutionInvalidity registries.
The "solutionInvalidity" is renamed as it now does more than its previous role.
We could also try to move this base class down from mooseBase into Action and mooseObject. This could simplify some code and remove this obnoxious issue with the template where I have to put the definitions in the mooseBase header still.
You would however loose the ability to output in MooseApp which is a MooseBase object (but not an Action or MooseObject)