Implement new closure system for turbulent mixing closures in SCM.#32221
Implement new closure system for turbulent mixing closures in SCM.#32221kyriv1980 wants to merge 15 commits intoidaholab:nextfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1912ec58c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Job Coverage, step Generate coverage on 98f37a5 wanted to post the following: Framework coverageCoverage did not change Modules coverageSubchannel
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
498dc0d to
358fba8
Compare
|
Job Documentation, step Docs: sync website on 98f37a5 wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
left a comment
There was a problem hiding this comment.
There are more than 1 closure lumped into these beta calculations. As long as the closures used are consistent between the problem and the closures in the beta we will be in a good spot if we need to change these closures
modules/subchannel/doc/content/source/scmclosures/SCMMixingChengTodreas.md
Outdated
Show resolved
Hide resolved
modules/subchannel/doc/content/source/scmclosures/SCMMixingConstantBeta.md
Show resolved
Hide resolved
modules/subchannel/doc/content/source/scmclosures/SCMMixingConstantBeta.md
Outdated
Show resolved
Hide resolved
1046d4b to
3db18c5
Compare
|
Job Precheck, step Clang format on 3db18c5 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
891666a to
a8c1cd7
Compare
|
Job Documentation public apps on a8c1cd7 : invalidated by @kyriv1980 |
|
Job Coverage, step Verify coverage on e52fda1 wanted to post the following: The following coverage requirement(s) failed:
|
|
Job Coverage on e52fda1 : invalidated by @kyriv1980 |
e52fda1 to
98f37a5
Compare
|
Job Test, step Results summary on 98f37a5 wanted to post the following: Framework test summaryCompared against 1363e1b in job civet.inl.gov/job/3552320. No change Modules test summaryCompared against 1363e1b in job civet.inl.gov/job/3552320. No added testsRun time changes
|
This PR resolves #30049.
Final Pr that completes the restructuring of the closure system in SCM.