Skip to content

Conversation

@kyriv1980
Copy link
Contributor

@kyriv1980 kyriv1980 commented Jan 13, 2026

This PR resolves #30049.

Final Pr that completes the restructuring of the closure system in SCM.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1912ec58c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@moosebuild
Copy link
Contributor

moosebuild commented Jan 13, 2026

Job Coverage, step Generate coverage on e52fda1 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Subchannel

54faeb #32221 e52fda
Total Total +/- New
Rate 93.48% 93.42% -0.05% 100.00%
Hits 6075 6121 +46 215
Misses 424 431 +7 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 14, 2026

Job Documentation, step Docs: sync website on e52fda1 wanted to post the following:

View the site here

This comment will be updated on new commits.

Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more than 1 closure lumped into these beta calculations. As long as the closures used are consistent between the problem and the closures in the beta we will be in a good spot if we need to change these closures

@kyriv1980 kyriv1980 force-pushed the mixing_closures branch 3 times, most recently from 1046d4b to 3db18c5 Compare January 19, 2026 22:34
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on 3db18c5 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/32221/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format ef2aa2d3b38c60949906e01820eed155306885a5

@kyriv1980 kyriv1980 force-pushed the mixing_closures branch 3 times, most recently from d9fed53 to 891666a Compare January 20, 2026 16:15
@moosebuild
Copy link
Contributor

Job Documentation public apps on a8c1cd7 : invalidated by @kyriv1980

@moosebuild
Copy link
Contributor

Job Test, step Results summary on e52fda1 wanted to post the following:

Framework test summary

Compared against 54faebe in job civet.inl.gov/job/3525342.

No change

Modules test summary

Compared against 54faebe in job civet.inl.gov/job/3525342.

No change

@moosebuild
Copy link
Contributor

Job Coverage, step Verify coverage on e52fda1 wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate ray_tracing coverage rate (required: 93.0%)
  • Failed to generate rdg coverage rate (required: 63.0%)
  • Failed to generate reactor coverage rate (required: 90.0%)
  • Failed to generate richards coverage rate (required: 93.0%)

@moosebuild
Copy link
Contributor

Job Coverage on e52fda1 : invalidated by @kyriv1980

@GiudGiud GiudGiud self-assigned this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abstract friction factor, heat transfer coefficients and turbulent mixing coefficients into a SCMClosures system in SCM

3 participants