-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement new closure system for turbulent mixing closures in SCM. #32221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1912ec58c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Job Coverage, step Generate coverage on e52fda1 wanted to post the following: Framework coverageCoverage did not change Modules coverageSubchannel
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
498dc0d to
358fba8
Compare
|
Job Documentation, step Docs: sync website on e52fda1 wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more than 1 closure lumped into these beta calculations. As long as the closures used are consistent between the problem and the closures in the beta we will be in a good spot if we need to change these closures
modules/subchannel/doc/content/source/scmclosures/SCMMixingChengTodreas.md
Outdated
Show resolved
Hide resolved
modules/subchannel/doc/content/source/scmclosures/SCMMixingConstantBeta.md
Show resolved
Hide resolved
modules/subchannel/doc/content/source/scmclosures/SCMMixingConstantBeta.md
Outdated
Show resolved
Hide resolved
1046d4b to
3db18c5
Compare
|
Job Precheck, step Clang format on 3db18c5 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
d9fed53 to
891666a
Compare
891666a to
a8c1cd7
Compare
|
Job Documentation public apps on a8c1cd7 : invalidated by @kyriv1980 |
|
Job Test, step Results summary on e52fda1 wanted to post the following: Framework test summaryCompared against 54faebe in job civet.inl.gov/job/3525342. No change Modules test summaryCompared against 54faebe in job civet.inl.gov/job/3525342. No change |
|
Job Coverage, step Verify coverage on e52fda1 wanted to post the following: The following coverage requirement(s) failed:
|
|
Job Coverage on e52fda1 : invalidated by @kyriv1980 |
This PR resolves #30049.
Final Pr that completes the restructuring of the closure system in SCM.