Use libmesh_terminate() for mooseError()
#32270
Draft
+306
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moosebuild
reviewed
Jan 27, 2026
Member
|
Shouldn't this be a one line change ;-) Can we make an option to opt out? Having the backtrace is sometimes nice to have. |
loganharbour
force-pushed
the
mooseerror_terminate
branch
from
52a2bb0 to
2235a71
Compare
Member
Author
You still get the backtrace |
moosebuild
reviewed
Jan 27, 2026
libmesh
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit c144a6e3ae9d721c0b780ac0035cff984c742ea1 | |||
| Subproject commit abfc985d8c03c671d6bd3621eaaafe7601f02185 | |||
Contributor
There was a problem hiding this comment.
Caution! This contains a submodule update
Member
Ok, cool, I guess we don't need to make the segfault opt-in :-D |
Contributor
|
Job Documentation, step Docs: sync website on ba5b5d0 wanted to post the following: View the site here This comment will be updated on new commits. |
loganharbour
force-pushed
the
mooseerror_terminate
branch
from
2235a71 to
49e6818
Compare
moosebuild
reviewed
Jan 28, 2026
| @@ -1 +1 @@ | |||
| Subproject commit c144a6e3ae9d721c0b780ac0035cff984c742ea1 | |||
| Subproject commit 502d42871efb6093844d2e02abe82bb15d48a033 | |||
Contributor
There was a problem hiding this comment.
Caution! This contains a submodule update
Contributor
|
Job Precheck, step Versioner verify on 49e6818 wanted to post the following: Versioner templatesFound 14 templates, 0 failed Versioner influential filesFound 57 influential files, 33 changed, 0 added, 1 removed
Versioner versionsFound 9 packages, 9 changed, 0 failed
|
Contributor
|
Job Coverage, step Generate coverage on ba5b5d0 wanted to post the following: Framework coverage
Modules coverageInconsistent report tags were found between the head and base reports. Inconsistent tags: Ray tracing
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
This lets us use the same idiom to stay in parallel sync for stack unwinding that we use to stay in parallel sync for e.g. time step reduction.
This fixes the problem where, if anything throws a non-MooseException here (including the new libmesh_terminate()), we were losing parallel sync and then dying when parallel_only destructors in stack unwinding conflicted with other parallel code.
This gets rid of an unnecessary/confusing "Unexpected exception type" message after the real error message that triggered program termination. We still get unnecessary/confusing "MPI_Abort" messages, but it'll be a while before we've figured out how to be certain we're in sync in these cases and can silently finalize instead.
This fixes parallel error handling for me
loganharbour
force-pushed
the
mooseerror_terminate
branch
from
49e6818 to
ed86949
Compare
Contributor
|
Job Test, step Results summary on ba5b5d0 wanted to post the following: Framework test summaryCompared against f855377 in job civet.inl.gov/job/3535487. No change Modules test summaryCompared against f855377 in job civet.inl.gov/job/3535487. No change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP