Create square duct mesh #31406 #32289
Open
+702
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
requested changes
Jan 29, 2026
modules/subchannel/doc/content/source/meshgenerators/SCMQuadDuctMeshGenerator.md
Outdated
Show resolved
Hide resolved
modules/subchannel/doc/content/source/meshgenerators/SCMQuadDuctMeshGenerator.md
Outdated
Show resolved
Hide resolved
modules/subchannel/src/meshgenerators/SCMQuadDuctMeshGenerator.C
Outdated
Show resolved
Hide resolved
modules/subchannel/src/meshgenerators/SCMQuadDuctMeshGenerator.C
Outdated
Show resolved
Hide resolved
modules/subchannel/src/meshgenerators/SCMQuadDuctMeshGenerator.C
Outdated
Show resolved
Hide resolved
modules/subchannel/src/meshgenerators/SCMQuadDuctMeshGenerator.C
Outdated
Show resolved
Hide resolved
modules/subchannel/src/meshgenerators/SCMQuadDuctMeshGenerator.C
Outdated
Show resolved
Hide resolved
Contributor
|
Job Documentation, step Docs: sync website on 6bc317e wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Job Coverage, step Generate coverage on 6bc317e wanted to post the following: Framework coverage
Modules coverageSubchannel
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
kyriv1980
force-pushed
the
quadDuct
branch
2 times, most recently
from
878e734 to
cf8f64d
Compare
GiudGiud
reviewed
Jan 30, 2026
modules/subchannel/test/tests/mesh/quad_subchannel_duct_mesh/tests
Outdated
Show resolved
Hide resolved
GiudGiud
reviewed
Jan 30, 2026
modules/subchannel/doc/content/source/meshgenerators/SCMQuadDuctMeshGenerator.md
Outdated
Show resolved
Hide resolved
kyriv1980
force-pushed
the
quadDuct
branch
2 times, most recently
from
a35b4f5 to
2817724
Compare
Contributor
|
Job Test, step Results summary on 6bc317e wanted to post the following: Framework test summaryCompared against e4407b3 in job civet.inl.gov/job/3542080. No change Modules test summaryCompared against e4407b3 in job civet.inl.gov/job/3542080. Added tests
Run time changes
|
GiudGiud
requested changes
Feb 3, 2026
Comment on lines
+58
to
+62
| * Function that returns the vector of the duct nodes. | ||
| * | ||
| * Over-writing to avoid abstract template definition in this class | ||
| * NOTE: must match base-class signature exactly (returns by value). | ||
| */ | ||
| ///@{ | ||
| virtual Node * getDuctNodeFromChannel(Node *) override { return nullptr; } | ||
| virtual Node * getChannelNodeFromDuct(Node *) override { return nullptr; } | ||
| virtual const std::vector<Node *> getDuctNodes() const override { return std::vector<Node *>(); } | ||
| ///@} | ||
| const std::vector<Node *> getDuctNodes() const override { return _duct_nodes; } |
Contributor
There was a problem hiding this comment.
Suggested change
| * Function that returns the vector of the duct nodes. | |
| * | |
| * Over-writing to avoid abstract template definition in this class | |
| * NOTE: must match base-class signature exactly (returns by value). | |
| */ | |
| ///@{ | |
| virtual Node * getDuctNodeFromChannel(Node *) override { return nullptr; } | |
| virtual Node * getChannelNodeFromDuct(Node *) override { return nullptr; } | |
| virtual const std::vector<Node *> getDuctNodes() const override { return std::vector<Node *>(); } | |
| ///@} | |
| const std::vector<Node *> getDuctNodes() const override { return _duct_nodes; } | |
| * Function that returns the vector of the duct nodes. | |
| */ | |
| const std::vector<Node *> & getDuctNodes() const override { return _duct_nodes; } |
a reference is likely enough and prevents the copy
Contributor
There was a problem hiding this comment.
you ll need to fix the base class and other derived classes since this is virtual
Comment on lines
+200
to
+211
| Node * | ||
| QuadSubChannelMesh::getDuctNodeFromChannel(Node * channel_node) const | ||
| { | ||
| auto it = _chan_to_duct_node_map.find(channel_node); | ||
| return (it == _chan_to_duct_node_map.end()) ? nullptr : it->second; | ||
| } | ||
|
|
||
| Node * | ||
| QuadSubChannelMesh::getChannelNodeFromDuct(Node * duct_node) const | ||
| { | ||
| auto it = _duct_node_to_chan_map.find(duct_node); | ||
| return (it == _duct_node_to_chan_map.end()) ? nullptr : it->second; |
Contributor
There was a problem hiding this comment.
these are exactly the same in the TriSubChannelMesh
why are they not defined in the parent class?
same for other routines most likely
| InputParameters params = MeshGenerator::validParams(); | ||
| params.addClassDescription("Creates a mesh of 2D duct cells around a square-lattice subassembly"); | ||
| params.addRequiredParam<MeshGeneratorName>("input", "The corresponding subchannel mesh"); | ||
| params.addParam<unsigned int>("block_id", 2, "Domain Index"); |
Contributor
There was a problem hiding this comment.
Suggested change
| params.addParam<unsigned int>("block_id", 2, "Domain Index"); | |
| params.addParam<unsigned int>("block_id", 2, "Subdomain id for the duct mesh cells"); |
Comment on lines
+34
to
+39
| "built a duct.[-]"); | ||
| params.addRangeCheckedParam<unsigned int>( | ||
| "ny", | ||
| "ny > 1", | ||
| "Number of channels in the y direction for the subchannel assembly. Must be more than 1 to " | ||
| "built a duct.[-]"); |
Contributor
There was a problem hiding this comment.
Suggested change
| "built a duct.[-]"); | |
| params.addRangeCheckedParam<unsigned int>( | |
| "ny", | |
| "ny > 1", | |
| "Number of channels in the y direction for the subchannel assembly. Must be more than 1 to " | |
| "built a duct.[-]"); | |
| "built a duct [-]"); | |
| params.addRangeCheckedParam<unsigned int>( | |
| "ny", | |
| "ny > 1", | |
| "Number of channels in the y direction for the subchannel assembly. Must be more than 1 to " | |
| "built a duct [-]"); |
|
|
||
| This mesh generator creates the mesh were the variables associated with the duct live. | ||
| This mesh generator creates the mesh (with Quad4 elements) where the variables associated with the duct live. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| The subdomain name used for the duct will match the name of this mesh generator. | |
same for the other one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #31406