Skip to content

Fix maximum update depth exceeded #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdoardoGruppi wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix maximum update depth exceeded #387

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66347d8
Add function to deeply compare arrays
Mar 28, 2024
fcf2a53
Fix bug (infinite render loop) caused by wrong dependence arrays
Mar 28, 2024
4bab637
Improve performance by using a new primitive variable to trigger events
Apr 15, 2024
845b5c4
Update test to handle date and milliseconds for the setCellData action
Apr 15, 2024
6432922
Remove redundant renderings
Apr 22, 2024
5a24c81
Fix rendering issue: table size
Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Spreadsheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
getCSV,
shouldHandleClipboardEvent,
isFocusedWithin,
deepArrayComparison,
} from "./util";

import DefaultTable from "./Table";
Expand Down Expand Up @@ -235,13 +236,12 @@ const Spreadsheet = <CellType extends Types.CellBase>(
// Listen to data changes
const prevDataRef = React.useRef<Matrix.Matrix<CellType>>(state.model.data);
React.useEffect(() => {
if (state.model.data !== prevDataRef.current) {
if (!deepArrayComparison(state.model.data, prevDataRef.current)) {
// Call on change only if the data change internal
if (state.model.data !== props.data) {
if (!deepArrayComparison(state.model.data, props.data)) {
Copy link
Owner

@iddan iddan Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but although this is a working solution for small datasets, for big ones it could be very problematic. The fix should be to make sure the reference isn't different in the first place.

onChange(state.model.data);
}
}

prevDataRef.current = state.model.data;
}, [state.model.data, onChange, props.data]);

Expand All @@ -252,7 +252,6 @@ const Spreadsheet = <CellType extends Types.CellBase>(
if (state?.model?.evaluatedData !== prevEvaluatedDataRef?.current) {
onEvaluatedDataChange(state?.model?.evaluatedData);
}

prevEvaluatedDataRef.current = state.model.evaluatedData;
}, [state?.model?.evaluatedData, onEvaluatedDataChange]);

Expand Down
11 changes: 11 additions & 0 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,17 @@ export function range(end: number, start = 0, step = 1): number[] {
return array;
}

/** Perform deep comparison of two (nested) arrays. */
export function deepArrayComparison(arr1: any[], arr2: any[]): boolean {
if (arr1.length !== arr2.length) return false;
return arr1.every((element, index) => {
if (Array.isArray(element) && Array.isArray(arr2[index])) {
return deepArrayComparison(element, arr2[index]);
}
return element === arr2[index];
});
}

/** Return whether given point is active */
export function isActive(
active: Types.StoreState["active"],
Expand Down