Fix Crossplatform mapping for Windows #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe priority range mappings for converting cross-platform thread priorities to Windows API thread priority enums were adjusted by shifting the lower bounds of several ranges down by one. This change modifies the mapping logic without altering the overall structure or error handling. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
groscoe2
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- src/windows.rs (1 hunks)
- tests/windows.rs (1 hunks)
Additional comments: 2
tests/windows.rs (1)
- 9-9: The addition of a new test case for a cross-platform value of 80 mapping to
WinAPIThreadPriority::Highestis a good practice to validate the changes made in the mapping logic. It ensures that the new value is correctly handled and mapped, enhancing the test coverage for the priority mapping functionality.src/windows.rs (1)
- 80-83: The adjustments made to the priority ranges in the
TryFrom<ThreadPriority> for WinAPIThreadPriorityimplementation correctly account for the previously missing values (20, 40, 60, and 80) by shifting the ranges forBelowNormal,Normal,AboveNormal, andHighestpriorities. This change ensures a more comprehensive and evenly distributed mapping across Windows thread priority values, aligning with the PR objectives.
Contributor
|
Hi, could this be merged? |
Owner
|
I am really sorry, I don't know how I missed this one! Sure. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading through the Crossplatform value mapping for Windows, I noticed that 20, 40, 60, and 80 were within the valid range of [0,99], but were not covered by the match statement. This PR updates the thread priority ranges to include each of these values as appropriate and also adds a test case for Crossplatform value 80. The ranges were adjusted to keep the Crossplatform values distributed as even as possible across the Windows thread priority values.