-
-
Notifications
You must be signed in to change notification settings - Fork 27
macOS support #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ rust: | |
| os: | ||
| - linux | ||
| - windows | ||
| - macos | ||
| dist: xenial | ||
| cache: | ||
| cargo: true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| //! This module defines the unix thread control. | ||
| //! | ||
| //! The crate's prelude doesn't have much control over | ||
| //! the unix threads, and this module provides | ||
| //! better control over those. | ||
|
|
||
| use crate::{Error, ThreadPriority}; | ||
|
|
||
| /// Return a placeholder type for the ThreadId. This is used in association with other types which are always errors on this unsupported platform (macOS) so this allows complilation and calling code has the option to handle the error gracefully at runtime | ||
| pub type ThreadId = i32; | ||
|
|
||
| /// Set current thread's priority. | ||
| pub fn set_current_thread_priority(_priority: ThreadPriority) -> Result<(), Error> { | ||
| // Silently do nothing- not a supported platform- priority will remain unchanged | ||
| Err(Error::UnsupportedPlatform()) | ||
| } | ||
|
|
||
| /// Get current thread's priority value. | ||
| pub fn thread_priority() -> Result<ThreadPriority, Error> { | ||
| // Indicate that this is not a supported platform | ||
| Err(Error::UnsupportedPlatform()) | ||
| } | ||
|
|
||
| /// Returns a placeholder for the current thread id. This is used in association with other types which are always errors on this unsupported platform (macOS) so this allows complilation and calling code has the option to handle the error gracefully at runtime | ||
| pub fn thread_native_id() -> ThreadId { | ||
| 0 | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask why did you remove the assertion? This was an example and a doc-test which was running and which was testing the library...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS it blows an error because the implementation there is a stub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the pattern which works in my application. "optional" thread priority change.
So you can pay attention to whether it is implemented for the current OS, but as an app developer you don't have to.