Conversation
[remove] unnecessary components and dependencies [fix] replace Repository Name bug
[optimize] app bar scroll effect, theme switch
TechQuery
requested changes
Dec 14, 2025
Comment on lines
-14
to
+4
| deploy: '部署', | ||
| welcome: "欢迎", |
Comment on lines
+55
to
+58
| "@parcel/config-default": "~2.16.1", | ||
| "@parcel/packager-raw-url": "~2.16.1", | ||
| "@parcel/transformer-typescript-tsc": "~2.16.1", | ||
| "@parcel/transformer-webmanifest": "~2.16.1", |
| declare module "react/jsx-runtime" { | ||
| namespace JSX { | ||
| interface IntrinsicElements { | ||
| "m3e-app-bar": CustomElement<M3eAppBarElement>; |
Member
There was a problem hiding this comment.
CustomElement 泛型是哪来的？
吐槽：M3E 竟然不内置 JSX 类型配置……
Comment on lines
+4
to
+11
| import { AppBar } from "./app-bar"; | ||
|
|
||
| import "@m3e/drawer-container"; | ||
| import "@m3e/nav-menu"; | ||
| import "@m3e/icon"; | ||
|
|
||
| import { t } from "../model/Translation"; | ||
| import { Setting } from "./setting"; |
Member
There was a problem hiding this comment.
Suggested change
| import { AppBar } from "./app-bar"; | |
| import "@m3e/drawer-container"; | |
| import "@m3e/nav-menu"; | |
| import "@m3e/icon"; | |
| import { t } from "../model/Translation"; | |
| import { Setting } from "./setting"; | |
| import "@m3e/drawer-container"; | |
| import "@m3e/nav-menu"; | |
| import "@m3e/icon"; | |
| import { t } from "../model/Translation"; | |
| import { AppBar } from "./app-bar"; | |
| import { Setting } from "./setting"; |
Comment on lines
+1
to
+8
| import type { FC } from "react"; | ||
|
|
||
| import "@m3e/app-bar"; | ||
| import "@m3e/icon"; | ||
| import "@m3e/icon-button"; | ||
| import "@m3e/menu"; | ||
|
|
||
| import { observer } from "mobx-react"; |
Member
There was a problem hiding this comment.
Suggested change
| import type { FC } from "react"; | |
| import "@m3e/app-bar"; | |
| import "@m3e/icon"; | |
| import "@m3e/icon-button"; | |
| import "@m3e/menu"; | |
| import { observer } from "mobx-react"; | |
| import { observer } from "mobx-react"; | |
| import type { FC } from "react"; | |
| import "@m3e/app-bar"; | |
| import "@m3e/icon"; | |
| import "@m3e/icon-button"; | |
| import "@m3e/menu"; |
Comment on lines
+32
to
+43
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| viewBox="0 0 98 96" | ||
| fill="currentColor" | ||
| > | ||
| <title>GitHub</title> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z" | ||
| /> | ||
| </svg> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡ You are currently on a Pull Request Badge free plan. Upgrade now to keep taking advantage of superior and streamlined badge generation!