Skip to content

chore: fix build with test mocks#224

Merged
idosal merged 1 commit intomainfrom
fix-tests
Mar 13, 2026
Merged

chore: fix build with test mocks#224
idosal merged 1 commit intomainfrom
fix-tests

Conversation

@idosal
Copy link
Owner

@idosal idosal commented Mar 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 13, 2026 01:21
@idosal idosal merged commit ed56be4 into main Mar 13, 2026
4 of 5 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Three.js repo handler unit test to avoid relying on live Three.js documentation fetches, making the test deterministic and fixing build instability caused by missing/undesired network behavior in tests.

Changes:

  • Added a fetchUrlContent mock for src/api/utils/cache to return stable JSON/HTML fixtures in the Three.js utils test.
  • Simplified the Three.js utils snapshot output to match the mocked HTML-to-markdown conversion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/api/tools/repoHandlers/threejs/utils.test.ts Reworks the test setup to mock fetchUrlContent and assert against a stable snapshot.
src/api/tools/repoHandlers/threejs/__snapshots__/utils.test.ts.snap Updates the snapshot to reflect the new mocked HTML content.
Comments suppressed due to low confidence (1)

src/api/tools/repoHandlers/threejs/utils.test.ts:52

  • The test name says it "should get the reference docs list as markdown" but the test actually calls getReferenceDocsContent(...). Renaming the it(...) description to match the behavior will keep the snapshot key and test output intention clear.
describe("Threejs Utils", () => {
  it("should get the reference docs list as markdown", async () => {
    const result = await getReferenceDocsContent({

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +5
const THREEJS_DOCS_REF_URL = "https://threejs.org/docs/list.json";
const THREEJS_MANUAL_REF_URL = "https://threejs.org/manual/list.json";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants