Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Three.js repo handler unit test to avoid relying on live Three.js documentation fetches, making the test deterministic and fixing build instability caused by missing/undesired network behavior in tests.
Changes:
- Added a
fetchUrlContentmock forsrc/api/utils/cacheto return stable JSON/HTML fixtures in the Three.js utils test. - Simplified the Three.js utils snapshot output to match the mocked HTML-to-markdown conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/api/tools/repoHandlers/threejs/utils.test.ts |
Reworks the test setup to mock fetchUrlContent and assert against a stable snapshot. |
src/api/tools/repoHandlers/threejs/__snapshots__/utils.test.ts.snap |
Updates the snapshot to reflect the new mocked HTML content. |
Comments suppressed due to low confidence (1)
src/api/tools/repoHandlers/threejs/utils.test.ts:52
- The test name says it "should get the reference docs list as markdown" but the test actually calls
getReferenceDocsContent(...). Renaming theit(...)description to match the behavior will keep the snapshot key and test output intention clear.
describe("Threejs Utils", () => {
it("should get the reference docs list as markdown", async () => {
const result = await getReferenceDocsContent({
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+5
| const THREEJS_DOCS_REF_URL = "https://threejs.org/docs/list.json"; | ||
| const THREEJS_MANUAL_REF_URL = "https://threejs.org/manual/list.json"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.