Correctly persist EmInput entities in CsvFileSink#1429
Correctly persist EmInput entities in CsvFileSink#1429pierrepetersmeier wants to merge 18 commits intodevfrom
Conversation
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
|
@pierrepetersmeier Could you add a test that reads in the persisted grid and compares it with the original grid? There are some test for grids without ems in |
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
|
Is this complete and only waiting for some review? @pierrepetersmeier |
…ing-a-jointgridcontainer
|
complete :) |
…ing-a-jointgridcontainer # Conflicts: # CHANGELOG.md
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Looks good except only little detail that may can be improved.
@pierrepetersmeier: is that done? Doesn't look like, to be honest :) |
…ing-a-jointgridcontainer
…use test failed with duplicate key exceptions due to shared output files
…while-persisting-a-jointgridcontainer' into pp/#1337-eminputs-arent-written-while-persisting-a-jointgridcontainer
…ing-a-jointgridcontainer
…ing-a-jointgridcontainer
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
I added the legacy energyManagementUnits which somehow got lost in another PR but should be here. However now some test is failing. It would be great if you could have a look on that.
| import edu.ie3.datamodel.io.processor.result.ResultEntityProcessor | ||
| import edu.ie3.datamodel.io.processor.timeseries.TimeSeriesProcessor | ||
| import edu.ie3.datamodel.io.processor.timeseries.TimeSeriesProcessorKey | ||
| import edu.ie3.datamodel.io.source.csv.CsvJointGridContainerSource |
There was a problem hiding this comment.
This import is not used.
| @@ -41,7 +40,7 @@ class GridIoIT extends Specification implements CsvTestDataMeta { | |||
| sinkHierarchic = new CsvFileSink(tempDirectory.toAbsolutePath(), hierarchicNamingStrategy, ",") | |||
| } | |||
|
|
|||
| def cleanupSpec() { | |||
There was a problem hiding this comment.
What are the reason behind these changes?
| thrown(FileException) | ||
| } | ||
|
|
||
| def "Input flat JointGridContainer with EmInput equals Output flat JointGridContainer."() { |
There was a problem hiding this comment.
It was really good that you added this test, since it disclosed that this is already covered by the first test in this file. So please remove this one and find out why persisting is not working yet (first test fails).
3 participants
Resolves #1337