Fixed some minor typos and inconsistencies in variable naming#1543
Merged
sebastian-peter merged 13 commits intodevfrom Feb 10, 2026
Merged
Fixed some minor typos and inconsistencies in variable naming#1543sebastian-peter merged 13 commits intodevfrom
sebastian-peter merged 13 commits intodevfrom
Conversation
danielfeismann
added
documentation
sebastian-peter
requested changes
Feb 9, 2026
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Thanks for cleaning up. Some comments from my side.
src/main/java/edu/ie3/datamodel/models/input/system/type/HpTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/HpTypeInput.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/factory/input/participant/EvcsInputFactoryTest.groovy
Show resolved
Hide resolved
Co-authored-by: Sebastian Peter <sebastian.peter@tu-dortmund.de>
sebastian-peter
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1542 and maybe makes #1396 easier to review
this PR