Removed ThermalUnits (duplication to ThermalGrids)#1547
Merged
sebastian-peter merged 3 commits intodevfrom Feb 12, 2026
Merged
Conversation
sebastian-peter
approved these changes
Feb 12, 2026
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Thanks for the cleaning! Didn't even realize that ThermalUnits was never even used anywhere
Member
Author
|
Me neither. Naming of classes is still not perfect. We have still ThermalUnitsResult, ThermalUnitInput... It would be great if they would match semantical together with ThermalGrid as we have that in other classes. However, ThermalGrid suites to me much better as collection for the houses and storages than this one here. Maybe someone has any good idea on this, we can further improve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #874