Skip to content

Feat/otel in dev#15

Merged
vitingr merged 2 commits intomainfrom
feat/otel-in-dev
Mar 19, 2026
Merged

Feat/otel in dev#15
vitingr merged 2 commits intomainfrom
feat/otel-in-dev

Conversation

@vitingr
Copy link
Contributor

@vitingr vitingr commented Mar 19, 2026

Summary by CodeRabbit

  • New Features

    • Added favicon endpoint response.
  • Chores

    • Extended telemetry collector to support HTTP protocol for OpenTelemetry metrics and traces.
    • Optimized HTTP auto-instrumentation to filter favicon requests and disabled unused instrumentation modules.

@vitingr vitingr merged commit 498c0dc into main Mar 19, 2026
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 242374f4-3e0e-4ebb-a171-00c90bc3bedd

📥 Commits

Reviewing files that changed from the base of the PR and between f490e1a and 1e7eb06.

📒 Files selected for processing (3)
  • devops/otel/collector-config.dev.yaml
  • src/app.ts
  • src/shared/infra/telemetry/otel.ts

📝 Walkthrough

Walkthrough

The pull request adds HTTP protocol support to the OpenTelemetry OTLP receiver, introduces a GET /favicon.ico endpoint returning 204 No Content, and expands telemetry instrumentation filtering to exclude favicon requests while disabling gRPC, filesystem, and DNS auto-instrumentation modules.

Changes

Cohort / File(s) Summary
OpenTelemetry Configuration
devops/otel/collector-config.dev.yaml
Added HTTP protocol endpoint listening on 0.0.0.0:4318 to OTLP receiver alongside existing gRPC endpoint.
Application Routing
src/app.ts
Added new HTTP GET endpoint for /favicon.ico that responds with status 204 and empty body.
Telemetry Instrumentation
src/shared/infra/telemetry/otel.ts
Expanded request filtering to ignore /favicon.ico in HTTP instrumentation hook; explicitly disabled auto-instrumentation for gRPC, filesystem, and DNS modules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A favicon's home, now here to stay,
HTTP whispers join gRPC's way,
Telemetry filters, quiet and wise,
No pings for favicons—clean skies!
With 204's grace, the web springs alive. 🌐✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/otel-in-dev
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant