Added support for UTF-8 characters less 32 or above 126 codes (out of ASCII range) #6
Conversation
| @@ -178,7 +177,7 @@ public void save(String dir, String fileName, boolean includeNamespace, String o | |||
| */ | |||
| public String toString(String tabs) | |||
| { | |||
| StringBuffer out = new StringBuffer(); | |||
| StringBuilder out = new StringBuilder(); | |||
There was a problem hiding this comment.
This is just a changed indentation (with one space?). Can be reverted.
| /** | ||
| * Encodes strings as XML. Check for <, >, ', ", &. | ||
| // /** | ||
| // * Encodes strings as XML. Check for <, >, ', ", &. |
There was a problem hiding this comment.
how about removing the commented out block? :)
| Pattern gtPat = Pattern.compile( ">" ); | ||
| Pattern aposPat = Pattern.compile( "\'" ); | ||
| Pattern quotPat = Pattern.compile( "\"" ); | ||
| static String encode(String originalUnprotectedString) { |
There was a problem hiding this comment.
The broken indentations in this method make it really hard to follow the flow
|
|
||
| String out = new String( in ); | ||
| StringBuilder stringBuffer = new StringBuilder(originalUnprotectedString.length()); |
There was a problem hiding this comment.
given that there are both StringBuffer and StringBuilder classes in java, I wouldn't call a variable of type StringBuilder like that. :) It's really misleading.
| anyCharactersProtected = true; | ||
| } | ||
| } | ||
| if (anyCharactersProtected == false) { |
There was a problem hiding this comment.
anyCharactersProtected is always true, as far as I can see.
I'd just get rid of this if block (and the whole anyCharactersProtected flag altogether) and always return stringBuffer.toString() as this seems like a really minor optimisation to me (if at all).
but if you want to keep it, then, probably, in the default case of the switch it should be:
default:
stringBuffer.append(ch);
anyCharactersProtected = false;
}
Hi,
I added additional encoding for UTF-8 characters which are out of standard ASCII range.